mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daejun Park <daejun7.park@samsung.com>
To: Bean Huo <beanhuo@iokpp.de>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"tomas.winkler@intel.com" <tomas.winkler@intel.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	Daejun Park <daejun7.park@samsung.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] scsi: ufs: core: Remove unnecessary if statement
Date: Fri, 14 Oct 2022 09:19:00 +0900	[thread overview]
Message-ID: <20221014001900epcms2p227bbd97b905dfc284028818e81781f76@epcms2p2> (raw)
In-Reply-To: <20221010092937.520013-2-beanhuo@iokpp.de>

Hi Bean,

> LUs with WB potential support are properly checked in ufshcd_wb_probe()
> before calling ufshcd_read_unit_desc_param(), so remove this unnecessary
> if-checkup in ufs_is_valid_unit_desc_lun() to match its function definition.
> 
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
>  drivers/ufs/core/ufshcd-priv.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
> index f68ca33f6ac7..2457b005101a 100644
> --- a/drivers/ufs/core/ufshcd-priv.h
> +++ b/drivers/ufs/core/ufshcd-priv.h
> @@ -300,9 +300,6 @@ static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info,
>                  pr_err("Max General LU supported by UFS isn't initialized\n");
>                  return false;
>          }
> -        /* WB is available only for the logical unit from 0 to 7 */
> -        if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)

Then, there is no requirement for "param_offset" argument.

Thanks,
Daejun


      parent reply	other threads:[~2022-10-14  0:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10  9:29 [PATCH v2 0/2] Changes for ufshcd.c Bean Huo
2022-10-10  9:29 ` [PATCH v2 1/2] scsi: ufs: core: Remove unnecessary if statement Bean Huo
2022-10-14 18:37   ` Bart Van Assche
2022-10-14 19:20     ` Bean Huo
2022-10-14 20:41       ` Bart Van Assche
2022-10-14 20:57         ` Bean Huo
2022-10-14 20:30     ` Bean Huo
2022-10-14 20:45       ` Bart Van Assche
2022-10-10  9:29 ` [PATCH v2 2/2] scsi: ufs: core: Cleanup ufshcd_slave_alloc() Bean Huo
2022-10-14 21:05   ` Bart Van Assche
2022-10-17 16:56     ` Bean Huo
     [not found] ` <CGME20221010093042epcas2p2462d3c50d81d613574332e3f39d971e1@epcms2p1>
2022-10-11  2:21   ` [PATCH v2 1/2] scsi: ufs: core: Remove unnecessary if statement Daejun Park
2022-10-11  9:39     ` Bean Huo
     [not found] ` <CGME20221010093042epcas2p2462d3c50d81d613574332e3f39d971e1@epcms2p2>
2022-10-14  0:19   ` Daejun Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221014001900epcms2p227bbd97b905dfc284028818e81781f76@epcms2p2 \
    --to=daejun7.park@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@iokpp.de \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®