From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78205C4332F for ; Sun, 16 Oct 2022 11:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbiJPLFi (ORCPT ); Sun, 16 Oct 2022 07:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229607AbiJPLFg (ORCPT ); Sun, 16 Oct 2022 07:05:36 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38E3E28727 for ; Sun, 16 Oct 2022 04:05:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DF0DBB80B91 for ; Sun, 16 Oct 2022 11:05:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EC2CC433C1; Sun, 16 Oct 2022 11:05:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665918332; bh=8GPCkdFugY38wC2Jh0RlLIcIb8fIVMIagkAF+T9gYAE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WPp3Ky2Gph19/Aj0KRkunIdzia+wxWTLdPtZ1du3WWgoCz3adqUurOIzYkU00/Ezd +GHkP00ssW3psZ1tfkh+xazTAfCuWsIs0Dam5TET4d6vuAEDNe926b4V3WdfJ3m57I V2TImuWgw3xBoAP+dMcLyt5NT6UrNdIej3eqdA8PXpivAKMGU4xs7sI3lQDrWyT4HW uajz6VhOFvQx0UUgvbfp0AXPU4BZJmxj6mJzebpoLv971ceL86wMyJNt4dxiYVuPDM nC8AZqrBh+QeeRLGLRkgKDz8ZkWf90+sT3uiQWWzzb9hqiBvxAqaY01Ny9cs7HsdCu 5wcxfSZ3UV2Gg== Received: by pali.im (Postfix) id 73E31A3A; Sun, 16 Oct 2022 13:05:29 +0200 (CEST) Date: Sun, 16 Oct 2022 13:05:29 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Christophe Leroy Cc: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Scott Wood , Sinan Akman , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/7] powerpc/85xx: Mark mpc85xx_ds_pic_init() as static Message-ID: <20221016110529.76bcgq2v2h4pg2of@pali> References: <20220819191557.28116-1-pali@kernel.org> <20220819191557.28116-3-pali@kernel.org> <20220926094706.km22rqzuuulvfssq@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220926094706.km22rqzuuulvfssq@pali> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Christophe! Do you have any other comments for this patch series? On Monday 26 September 2022 11:47:06 Pali Rohár wrote: > On Monday 26 September 2022 09:43:55 Christophe Leroy wrote: > > Le 19/08/2022 à 21:15, Pali Rohár a écrit : > > > Function mpc85xx_ds_pic_init() is not used out of the mpc85xx_ds.c file. > > > > > > Signed-off-by: Pali Rohár > > > > This patch should be squashed into patch 1. > > No problem. Just to explain that I split those changes into different > patches because they touch different files and different board code. > And I thought that different things should be in different patches. > > > > --- > > > arch/powerpc/platforms/85xx/mpc85xx_ds.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > > index f8d2c97f39bd..9a6d637ef54a 100644 > > > --- a/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > > +++ b/arch/powerpc/platforms/85xx/mpc85xx_ds.c > > > @@ -54,7 +54,7 @@ static void mpc85xx_8259_cascade(struct irq_desc *desc) > > > } > > > #endif /* CONFIG_PPC_I8259 */ > > > > > > -void __init mpc85xx_ds_pic_init(void) > > > +static void __init mpc85xx_ds_pic_init(void) > > > { > > > struct mpic *mpic; > > > #ifdef CONFIG_PPC_I8259