From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D66BC433FE for ; Mon, 17 Oct 2022 00:41:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229882AbiJQAlB (ORCPT ); Sun, 16 Oct 2022 20:41:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbiJQAkh (ORCPT ); Sun, 16 Oct 2022 20:40:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 931A1360B7 for ; Sun, 16 Oct 2022 17:40:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 21899B80D5B for ; Mon, 17 Oct 2022 00:40:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B98BAC433C1; Mon, 17 Oct 2022 00:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1665967233; bh=DdTOCukEn0G9bfVE8ZyKClnyxvtSZtfh7HrKBPqPF/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oqlrAv/YTMgHHkJBw3hrVCRXayWG27j3E9uGvj7sJ1WkEoQMzPESwg+y2HgOvfMMN bfvYRQubOz3YUcHUck/9/I9GZoDGBpCG74EgkcmZwgoFplDxGvaoQu/dhEiXRPeXXQ rCNLS5MNSFBYDYeiYNUjDz5v1MXGIcwPDByqFQNQ= Date: Sun, 16 Oct 2022 17:40:33 -0700 From: Andrew Morton To: Peter Oberparleiter Cc: Martin =?UTF-8?B?TGnFoWth?= , linux-kernel@vger.kernel.org Subject: Re: [PATCH] gcov: support GCC 12.1 and newer compilers Message-Id: <20221016174033.d33a998b4c91b7d18b3dc310@linux-foundation.org> In-Reply-To: <581f6037-ff43-4f91-cabf-d9aa0d72bbe6@linux.ibm.com> References: <624bda92-f307-30e9-9aaa-8cc678b2dfb2@suse.cz> <581f6037-ff43-4f91-cabf-d9aa0d72bbe6@linux.ibm.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Oct 2022 11:30:51 +0200 Peter Oberparleiter wrote: > On 13.10.2022 09:40, Martin Liška wrote: > > Starting with GCC 12.1, there are 2 significant changes to the .gcda > > file format that needs to be supported: > > > > a) [gcov: Use system IO buffering] (23eb66d1d46a34cb28c4acbdf8a1deb80a7c5a05) changed > > that all sizes in the format are in bytes and not in words (4B) > > b) [gcov: make profile merging smarter] (72e0c742bd01f8e7e6dcca64042b9ad7e75979de) > > add a new checksum to the file header. > > > > Tested with GCC 7.5, 10.4, 12.2 and the current master. > > > > Signed-off-by: Martin Liska > > Looks good, thanks! I successfully tested this patch on s390 using GCC > 12.2 and 11.2. > > Tested-by: Peter Oberparleiter > Reviewed-by: Peter Oberparleiter > > Andrew, could you add this patch via your tree? Sure. The changelog doesn't tell us what the user-visible effects of this are (please, it should do so), but it sounds to me like those effects are "gcov is utterly busted". So I'll add a cc:stable to this, so that people can use new gcc versions to build older kernels.