From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E899C433FE for ; Mon, 17 Oct 2022 02:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230319AbiJQC3I (ORCPT ); Sun, 16 Oct 2022 22:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230307AbiJQC3G (ORCPT ); Sun, 16 Oct 2022 22:29:06 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 998D81A044 for ; Sun, 16 Oct 2022 19:29:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5D513B80E4A for ; Mon, 17 Oct 2022 02:29:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE086C433D7; Mon, 17 Oct 2022 02:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1665973743; bh=jsK3qEANRyPmKldiqe7w+EnAwbL36O8N4IwTdPMdRJ0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gc5KnyyetB5mVmEtwZOa+ZpMS4OWiQa413XQbPSysavRW07fvPr8ZZMP4fF2dvzIT CrJ+ic+eyoAs1DxGaxANoDZ9OFhG4X3tdPS/Q4umCXzUi6xwjR2JZLCFu+pebIUdok uA1b0kCJvpC5TXe8cEG9dTgrr8ckLBeg5ioVarJY= Date: Sun, 16 Oct 2022 19:29:02 -0700 From: Andrew Morton To: Joseph Qi Cc: Gang He , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH] ocfs2: reflink deadlock when clone file to the same directory simultaneously Message-Id: <20221016192902.4d7e70047ca5d04a2f585688@linux-foundation.org> In-Reply-To: <06a7f382-5eaa-9489-3c28-aa4bfb804327@gmail.com> References: <20210729110230.18983-1-ghe@suse.com> <5821fd0f-2018-dc1b-a5c0-f948a7debff4@linux.alibaba.com> <71608a14-58f4-dba0-d695-fee65de89192@linux.alibaba.com> <801438f5-655a-c708-aa25-343d54a2f11e@suse.com> <86e3d724-3147-ccaa-998f-0f857c575f7e@linux.alibaba.com> <4ba3b404-824b-90a3-ef43-9ab6510ee073@linux.alibaba.com> <5a1af56c-3eab-5baf-62a3-1c98bac104ba@suse.com> <20221016162950.09db2b5f503ac87823cd1687@linux-foundation.org> <06a7f382-5eaa-9489-3c28-aa4bfb804327@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Oct 2022 09:51:14 +0800 Joseph Qi wrote: > Hi Andrew, > > On 10/17/22 7:29 AM, Andrew Morton via Ocfs2-devel wrote: > > On Thu, 26 Aug 2021 13:56:16 +0800 Gang He wrote: > > > >> So, I will send a new patch to fix this deadlock problem via dlmglue layer. > >> For this patch, I want to change the patch comments as a reflink > >> improvement patch. > > > > Did this ever happen? I've been sitting on this patch for ages. > > > Looked back this thread, the root cause of deadlock seems to be the > asynchronous of fsdlm handling. So this is not a right fix. > While for the performance improvement, I need some test data as well. OK, thanks, I dropped the patch.