mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Manank Patel <pmanank200502@gmail.com>
Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()")
Date: Mon, 17 Oct 2022 19:20:35 +0100	[thread overview]
Message-ID: <20221017182035.3g67uudttl6k5gag@bogus> (raw)
In-Reply-To: <20221017174915.45916-1-pmanank200502@gmail.com>

On Mon, Oct 17, 2022 at 11:19:15PM +0530, Manank Patel wrote:
> Fixed unintentional u32 overflow by changing PCC_CMD_WAIT_RETRIES_NUM to 500ULL
> 

You just need to add the below fixes line above Signed-off tag. You seemed
to have changed the $subject. Please retain the origin subject

Please post it again cleanly marking it as v2(as in the subject must be
[PATCH v2] "ACPI: PCC: Fix unintentional integer overflow" 

Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()")
> Signed-off-by: Manank Patel <pmanank200502@gmail.com>
> ---
> 
> Sorry for the spam, I made a mistake in the previous patch (I had a confusion 
> in your suggestion about the Fixes tag).As you would have realised, i'm new 
> to this, and not so familiar with the workflow (Though I have read the 
> Documentation). Let me know if you have any suggestions.
>

Add a text here pointing what changed from v1->v2
v1->v2:
	Change the macro itself ULL instead typecasting in the code

Hope this helps.

With all these changes incorporated in v2, you can add my
Acked-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

  reply	other threads:[~2022-10-17 18:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13  5:49 [PATCH] ACPI: acpi_pcc.c: Fix unintentional integer overflow pmanank200502
2022-10-13 11:42 ` Rafael J. Wysocki
2022-10-13 13:03   ` [PATCH] Fixes: 91cefefb6991 ("ACPI: acpi_pcc.c: fixed unintentional u32 overflow by redefining a constant") Manank Patel
2022-10-17 17:49     ` [PATCH] Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()") Manank Patel
2022-10-17 18:20       ` Sudeep Holla [this message]
2022-10-17 18:43         ` [PATCH v2] "ACPI: PCC: Fix unintentional integer overflow" Manank Patel
2022-10-18  1:12           ` lihuisong (C)
2022-10-26 11:34             ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221017182035.3g67uudttl6k5gag@bogus \
    --to=sudeep.holla@arm.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmanank200502@gmail.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®