mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan Brattlof <bb@ti.com>
To: Andrew Davis <afd@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/10] AM64x Disable Incomplete DT Nodes
Date: Tue, 18 Oct 2022 10:24:11 -0500	[thread overview]
Message-ID: <20221018152411.iguw2mg27ahexq2e@bryanbrattlof.com> (raw)
In-Reply-To: <20221017192532.23825-1-afd@ti.com>

On October 17, 2022 thus sayeth Andrew Davis:
> Hello all,
> 
> This series goes through the AM64x dtsi and disables the set of nodes
> that are not functional without additional board level information.
> This is usually pinmux data, but can also be inernal device resources.
> 
> Only when the node is completed in the board file should the node be
> enabled. This helps prevents nodes that represent IP that are not
> pinned-out on a given board from being left enabled.
> 
> This also reduces the effort needed to add a new board, one no longer
> needs to manually disable all the extra IP. For instance TI J784s4 has
> 20(!) MCAN instances. It is much easier to enable the one you pin out,
> vs disabling the 19 that you did not.
> 
> Thanks,
> Andrew
> 
> Andrew Davis (10):
>   arm64: dts: ti: k3-am64: Enable UART nodes at the board level
>   arm64: dts: ti: k3-am64: Enable I2C nodes at the board level
>   arm64: dts: ti: k3-am64: Enable SPI nodes at the board level
>   arm64: dts: ti: k3-am64: Enable EPWM nodes at the board level
>   arm64: dts: ti: k3-am64: Enable ECAP nodes at the board level
>   arm64: dts: ti: k3-am64: Enable PCIe nodes at the board level
>   arm64: dts: ti: k3-am64: MDIO pinmux should belong to the MDIO node
>   arm64: dts: ti: k3-am64: Enable MDIO nodes at the board level
>   arm64: dts: ti: k3-am64: Enable MCAN nodes at the board level
>   arm64: dts: ti: k3-am64: Enable GPMC and ELM nodes at the board level
> 
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi |  37 ++++++
>  arch/arm64/boot/dts/ti/k3-am64-mcu.dtsi  |   6 +
>  arch/arm64/boot/dts/ti/k3-am642-evm.dts  | 119 ++-----------------
>  arch/arm64/boot/dts/ti/k3-am642-sk.dts   | 142 ++---------------------
>  4 files changed, 63 insertions(+), 241 deletions(-)
> 

Reviewed-by: Bryan Brattlof <bb@ti.com>

I wholeheartedly agree! This looks great to me!

~Bryan

  parent reply	other threads:[~2022-10-18 15:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 19:25 Andrew Davis
2022-10-17 19:25 ` [PATCH 01/10] arm64: dts: ti: k3-am64: Enable UART nodes at the board level Andrew Davis
2022-10-17 19:25 ` [PATCH 02/10] arm64: dts: ti: k3-am64: Enable I2C " Andrew Davis
2022-10-17 19:25 ` [PATCH 03/10] arm64: dts: ti: k3-am64: Enable SPI " Andrew Davis
2022-10-17 19:25 ` [PATCH 04/10] arm64: dts: ti: k3-am64: Enable EPWM " Andrew Davis
2022-10-17 19:25 ` [PATCH 05/10] arm64: dts: ti: k3-am64: Enable ECAP " Andrew Davis
2022-10-17 19:25 ` [PATCH 06/10] arm64: dts: ti: k3-am64: Enable PCIe " Andrew Davis
2022-10-17 19:25 ` [PATCH 07/10] arm64: dts: ti: k3-am64: MDIO pinmux should belong to the MDIO node Andrew Davis
2022-10-17 19:25 ` [PATCH 08/10] arm64: dts: ti: k3-am64: Enable MDIO nodes at the board level Andrew Davis
2022-10-17 19:25 ` [PATCH 09/10] arm64: dts: ti: k3-am64: Enable MCAN " Andrew Davis
2022-10-17 19:25 ` [PATCH 10/10] arm64: dts: ti: k3-am64: Enable GPMC and ELM " Andrew Davis
2022-10-18 15:24 ` Bryan Brattlof [this message]
2022-10-27  6:33 ` [PATCH 00/10] AM64x Disable Incomplete DT Nodes Vignesh Raghavendra
2022-10-28 13:30 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221018152411.iguw2mg27ahexq2e@bryanbrattlof.com \
    --to=bb@ti.com \
    --cc=afd@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®