Hi Gao, I love your patch! Yet something to improve: [auto build test ERROR on xiang-erofs/dev-test] [also build test ERROR on linus/master v6.1-rc1 next-20221018] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Gao-Xiang/erofs-use-kmap_local_page-only-for-erofs_bread/20221018-115613 base: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test patch link: https://lore.kernel.org/r/20221018035536.114792-1-hsiangkao%40linux.alibaba.com patch subject: [PATCH] erofs: use kmap_local_page() only for erofs_bread() config: i386-randconfig-a003 compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/434a5b6093794608b7a4ed9ab12164b506dc883f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Gao-Xiang/erofs-use-kmap_local_page-only-for-erofs_bread/20221018-115613 git checkout 434a5b6093794608b7a4ed9ab12164b506dc883f # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash fs/erofs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from : In function 'erofs_unmap_metabuf', inlined from 'erofs_put_metabuf' at fs/erofs/data.c:25:2, inlined from 'erofs_iomap_end' at fs/erofs/data.c:320:3: >> include/linux/compiler_types.h:357:45: error: call to '__compiletime_assert_318' declared with attribute error: BUILD_BUG_ON failed: __same_type((buf->page), struct page *) 357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:338:25: note: in definition of macro '__compiletime_assert' 338 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:357:9: note: in expansion of macro '_compiletime_assert' 357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ include/linux/highmem-internal.h:283:9: note: in expansion of macro 'BUILD_BUG_ON' 283 | BUILD_BUG_ON(__same_type((__addr), struct page *)); \ | ^~~~~~~~~~~~ fs/erofs/data.c:16:17: note: in expansion of macro 'kunmap_local' 16 | kunmap_local(buf->page); | ^~~~~~~~~~~~ fs/erofs/data.c: In function 'erofs_unmap_metabuf': >> include/linux/compiler_types.h:357:45: error: call to '__compiletime_assert_318' declared with attribute error: BUILD_BUG_ON failed: __same_type((buf->page), struct page *) 357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:338:25: note: in definition of macro '__compiletime_assert' 338 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:357:9: note: in expansion of macro '_compiletime_assert' 357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ include/linux/highmem-internal.h:283:9: note: in expansion of macro 'BUILD_BUG_ON' 283 | BUILD_BUG_ON(__same_type((__addr), struct page *)); \ | ^~~~~~~~~~~~ fs/erofs/data.c:16:17: note: in expansion of macro 'kunmap_local' 16 | kunmap_local(buf->page); | ^~~~~~~~~~~~ In function 'erofs_unmap_metabuf', inlined from 'erofs_put_metabuf' at fs/erofs/data.c:25:2: >> include/linux/compiler_types.h:357:45: error: call to '__compiletime_assert_318' declared with attribute error: BUILD_BUG_ON failed: __same_type((buf->page), struct page *) 357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:338:25: note: in definition of macro '__compiletime_assert' 338 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:357:9: note: in expansion of macro '_compiletime_assert' 357 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:50:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition) | ^~~~~~~~~~~~~~~~ include/linux/highmem-internal.h:283:9: note: in expansion of macro 'BUILD_BUG_ON' 283 | BUILD_BUG_ON(__same_type((__addr), struct page *)); \ | ^~~~~~~~~~~~ fs/erofs/data.c:16:17: note: in expansion of macro 'kunmap_local' 16 | kunmap_local(buf->page); | ^~~~~~~~~~~~ vim +/__compiletime_assert_318 +357 include/linux/compiler_types.h eb5c2d4b45e3d2 Will Deacon 2020-07-21 343 eb5c2d4b45e3d2 Will Deacon 2020-07-21 344 #define _compiletime_assert(condition, msg, prefix, suffix) \ eb5c2d4b45e3d2 Will Deacon 2020-07-21 345 __compiletime_assert(condition, msg, prefix, suffix) eb5c2d4b45e3d2 Will Deacon 2020-07-21 346 eb5c2d4b45e3d2 Will Deacon 2020-07-21 347 /** eb5c2d4b45e3d2 Will Deacon 2020-07-21 348 * compiletime_assert - break build and emit msg if condition is false eb5c2d4b45e3d2 Will Deacon 2020-07-21 349 * @condition: a compile-time constant condition to check eb5c2d4b45e3d2 Will Deacon 2020-07-21 350 * @msg: a message to emit if condition is false eb5c2d4b45e3d2 Will Deacon 2020-07-21 351 * eb5c2d4b45e3d2 Will Deacon 2020-07-21 352 * In tradition of POSIX assert, this macro will break the build if the eb5c2d4b45e3d2 Will Deacon 2020-07-21 353 * supplied condition is *false*, emitting the supplied error message if the eb5c2d4b45e3d2 Will Deacon 2020-07-21 354 * compiler has support to do so. eb5c2d4b45e3d2 Will Deacon 2020-07-21 355 */ eb5c2d4b45e3d2 Will Deacon 2020-07-21 356 #define compiletime_assert(condition, msg) \ eb5c2d4b45e3d2 Will Deacon 2020-07-21 @357 _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) eb5c2d4b45e3d2 Will Deacon 2020-07-21 358 -- 0-DAY CI Kernel Test Service https://01.org/lkp