From: chengwei <foxfly.lai.tw@gmail.com>
To: lee@kernel.org, broonie@kernel.org, rafael@kernel.org,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, linus.walleij@linaro.org,
brgl@bgdev.pl
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-gpio@vger.kernel.org, GaryWang@aaeon.com.tw,
musa.lin@yunjingtech.com, jack.chang@yunjingtech.com,
chengwei <larry.lai@yunjingtech.com>
Subject: [PATCH 4/5] GPIO ACPI: Add support to map GPIO resources to ranges
Date: Wed, 19 Oct 2022 10:24:49 +0800 [thread overview]
Message-ID: <20221019022450.16851-5-larry.lai@yunjingtech.com> (raw)
In-Reply-To: <20221019022450.16851-1-larry.lai@yunjingtech.com>
Add a function to gpiolib to facilitate registering a pin controller for
a range of GPIO pins, but using ACPI resource references and without
claiming the GPIO resource.
Signed-off-by: chengwei <larry.lai@yunjingtech.com>
---
drivers/gpio/gpiolib-acpi.c | 88 ++++++++++++++++++++++++++++++-------
1 file changed, 71 insertions(+), 17 deletions(-)
diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 9be1376f9a62..d25c6cb610e3 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -1385,6 +1385,32 @@ static int acpi_find_gpio_count(struct acpi_resource *ares, void *data)
return 1;
}
+static int acpi_gpio_count_from_property(struct acpi_device *adev,
+ const char *propname)
+{
+ const struct acpi_gpio_mapping *gm;
+ const union acpi_object *obj;
+ int count = -ENOENT;
+ int ret;
+
+ ret = acpi_dev_get_property(adev, propname, ACPI_TYPE_ANY,
+ &obj);
+ if (ret == 0) {
+ if (obj->type == ACPI_TYPE_LOCAL_REFERENCE)
+ count = 1;
+ else if (obj->type == ACPI_TYPE_PACKAGE)
+ count = acpi_gpio_package_count(obj);
+ } else if (adev->driver_gpios) {
+ for (gm = adev->driver_gpios; gm->name; gm++)
+ if (strcmp(propname, gm->name) == 0) {
+ count = gm->size;
+ break;
+ }
+ }
+
+ return count;
+}
+
/**
* acpi_gpio_count - count the GPIOs associated with a device / function
* @dev: GPIO consumer, can be %NULL for system-global GPIOs
@@ -1397,10 +1423,7 @@ static int acpi_find_gpio_count(struct acpi_resource *ares, void *data)
int acpi_gpio_count(struct device *dev, const char *con_id)
{
struct acpi_device *adev = ACPI_COMPANION(dev);
- const union acpi_object *obj;
- const struct acpi_gpio_mapping *gm;
int count = -ENOENT;
- int ret;
char propname[32];
unsigned int i;
@@ -1413,20 +1436,7 @@ int acpi_gpio_count(struct device *dev, const char *con_id)
snprintf(propname, sizeof(propname), "%s",
gpio_suffixes[i]);
- ret = acpi_dev_get_property(adev, propname, ACPI_TYPE_ANY,
- &obj);
- if (ret == 0) {
- if (obj->type == ACPI_TYPE_LOCAL_REFERENCE)
- count = 1;
- else if (obj->type == ACPI_TYPE_PACKAGE)
- count = acpi_gpio_package_count(obj);
- } else if (adev->driver_gpios) {
- for (gm = adev->driver_gpios; gm->name; gm++)
- if (strcmp(propname, gm->name) == 0) {
- count = gm->size;
- break;
- }
- }
+ count = acpi_gpio_count_from_property(adev, propname);
if (count > 0)
break;
}
@@ -1449,6 +1459,50 @@ int acpi_gpio_count(struct device *dev, const char *con_id)
return count ? count : -ENOENT;
}
+/**
+ * acpi_node_add_pin_mapping - add a pin mapping for named GPIO resources
+ * @fwnode: pointer to an ACPI firmware node to get the GPIO information from
+ * @propname: Property name of the GPIO
+ * @pinctrl_name: the dev_name() of the pin controller to map to
+ * @pin_offset: the start offset in the pin controller number space
+ * @npins: the maximum number of pins from the offset of each pin space (GPIO
+ * and pin controller) to map
+ *
+ * Lookup the GPIO resources and map them individually to the specified pins.
+ */
+int acpi_node_add_pin_mapping(struct fwnode_handle *fwnode,
+ const char *propname,
+ const char *pinctl_name,
+ unsigned int pin_offset,
+ unsigned int npins)
+{
+ struct acpi_device *adev = to_acpi_device_node(fwnode);
+ int count, i;
+
+ count = acpi_gpio_count_from_property(adev, propname);
+ if (count < 0)
+ return count;
+
+ for (i = 0; i < count && i < npins; i++) {
+ struct gpio_desc *desc;
+ int ret;
+
+ desc = acpi_node_get_gpiod(fwnode, propname, i, NULL);
+ if (IS_ERR(desc))
+ return PTR_ERR(desc);
+
+ /* The GPIOs may not be contiguous, so add them 1-by-1 */
+ ret = gpiochip_add_pin_range(gpiod_to_chip(desc), pinctl_name,
+ gpio_chip_hwgpio(desc),
+ pin_offset + i, 1);
+ if (ret)
+ return ret;
+ }
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(acpi_node_add_pin_mapping);
+
/* Run deferred acpi_gpiochip_request_irqs() */
static int __init acpi_gpio_handle_deferred_request_irqs(void)
{
--
2.17.1
next prev parent reply other threads:[~2022-10-19 2:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 2:24 [PATCH 0/5] Add support control UP board CPLD/FPGA pin control chengwei
2022-10-19 2:24 ` [PATCH 1/5] mfd: Add support for UP board CPLD/FPGA chengwei
2022-10-31 14:58 ` Lee Jones
[not found] ` <SG2PR06MB37422173908A6584B3D6D349F93F9@SG2PR06MB3742.apcprd06.prod.outlook.com>
2022-11-08 15:53 ` 回覆: " gregkh
[not found] ` <SG2PR06MB3742D3714B6A255914DC73E4F93F9@SG2PR06MB3742.apcprd06.prod.outlook.com>
2022-11-08 17:24 ` gregkh
2022-11-14 10:09 ` Lee Jones
2022-11-09 4:18 ` Larry Lai
2022-10-19 2:24 ` [PATCH 2/5] regmap: Expose regmap_writeable function to check if a register is writable chengwei
2022-10-19 11:57 ` Mark Brown
2022-10-19 2:24 ` [PATCH 3/5] ACPI: acpi_node_add_pin_mapping added to header file chengwei
2022-10-19 13:32 ` Andy Shevchenko
2022-10-19 2:24 ` chengwei [this message]
2022-10-19 13:36 ` [PATCH 4/5] GPIO ACPI: Add support to map GPIO resources to ranges Andy Shevchenko
2022-10-19 2:24 ` [PATCH 5/5] pinctrl: Add support pin control for UP board CPLD/FPGA chengwei
2022-10-20 16:58 ` Andy Shevchenko
2022-10-21 9:09 ` Linus Walleij
2022-10-21 10:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019022450.16851-5-larry.lai@yunjingtech.com \
--to=foxfly.lai.tw@gmail.com \
--cc=GaryWang@aaeon.com.tw \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jack.chang@yunjingtech.com \
--cc=larry.lai@yunjingtech.com \
--cc=lee@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=musa.lin@yunjingtech.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®