Hi Steen, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Steen-Hegelund/Add-support-for-Sparx5-IS2-VCAP/20221018-193618 patch link: https://lore.kernel.org/r/20221018113156.2364533-10-steen.hegelund%40microchip.com patch subject: [PATCH net-next 9/9] net: microchip: sparx5: Adding KUNIT test for the VCAP API config: mips-allyesconfig compiler: mips-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/bcdfdb20e273a9ff3dc4a07e4cd6ca3a4d5319cf git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Steen-Hegelund/Add-support-for-Sparx5-IS2-VCAP/20221018-193618 git checkout bcdfdb20e273a9ff3dc4a07e4cd6ca3a4d5319cf # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:992:10: error: 'VCAP_KFS_IP6_STD' undeclared here (not in a function); did you mean 'VCAP_KFS_IP6_VID'? 992 | [VCAP_KFS_IP6_STD] = { | ^~~~~~~~~~~~~~~~ | VCAP_KFS_IP6_VID >> drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:992:10: error: array index in initializer not of integer type drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:992:10: note: (near initialization for 'is2_keyfield_set') drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:992:30: warning: initialized field overwritten [-Woverride-init] 992 | [VCAP_KFS_IP6_STD] = { | ^ drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:992:30: note: (near initialization for 'is2_keyfield_set[4]') drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1010:10: error: array index in initializer not of integer type 1010 | [VCAP_KFS_IP6_STD] = is2_ip6_std_keyfield, | ^~~~~~~~~~~~~~~~ drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1010:10: note: (near initialization for 'is2_keyfield_set_map') drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1010:30: warning: initialized field overwritten [-Woverride-init] 1010 | [VCAP_KFS_IP6_STD] = is2_ip6_std_keyfield, | ^~~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1010:30: note: (near initialization for 'is2_keyfield_set_map[4]') drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1020:10: error: array index in initializer not of integer type 1020 | [VCAP_KFS_IP6_STD] = ARRAY_SIZE(is2_ip6_std_keyfield), | ^~~~~~~~~~~~~~~~ drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1020:10: note: (near initialization for 'is2_keyfield_set_map_size') In file included from drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:11: include/linux/kernel.h:55:25: warning: initialized field overwritten [-Woverride-init] 55 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) | ^ drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1020:30: note: in expansion of macro 'ARRAY_SIZE' 1020 | [VCAP_KFS_IP6_STD] = ARRAY_SIZE(is2_ip6_std_keyfield), | ^~~~~~~~~~ include/linux/kernel.h:55:25: note: (near initialization for 'is2_keyfield_set_map_size[4]') 55 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) | ^ drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1020:30: note: in expansion of macro 'ARRAY_SIZE' 1020 | [VCAP_KFS_IP6_STD] = ARRAY_SIZE(is2_ip6_std_keyfield), | ^~~~~~~~~~ drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1222:10: error: array index in initializer not of integer type 1222 | [VCAP_KFS_IP6_STD] = "VCAP_KFS_IP6_STD", | ^~~~~~~~~~~~~~~~ drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c:1222:10: note: (near initialization for 'vcap_keyfield_set_names') vim +992 drivers/net/ethernet/microchip/sparx5/sparx5_vcap_ag_api.c 04461a7e89447de3 Steen Hegelund 2022-10-18 969 04461a7e89447de3 Steen Hegelund 2022-10-18 970 /* keyfield_set */ 04461a7e89447de3 Steen Hegelund 2022-10-18 971 static const struct vcap_set is2_keyfield_set[] = { 04461a7e89447de3 Steen Hegelund 2022-10-18 972 [VCAP_KFS_MAC_ETYPE] = { 04461a7e89447de3 Steen Hegelund 2022-10-18 973 .type_id = 0, 04461a7e89447de3 Steen Hegelund 2022-10-18 974 .sw_per_item = 6, 04461a7e89447de3 Steen Hegelund 2022-10-18 975 .sw_cnt = 2, 04461a7e89447de3 Steen Hegelund 2022-10-18 976 }, 04461a7e89447de3 Steen Hegelund 2022-10-18 977 [VCAP_KFS_ARP] = { 04461a7e89447de3 Steen Hegelund 2022-10-18 978 .type_id = 3, 04461a7e89447de3 Steen Hegelund 2022-10-18 979 .sw_per_item = 6, 04461a7e89447de3 Steen Hegelund 2022-10-18 980 .sw_cnt = 2, 04461a7e89447de3 Steen Hegelund 2022-10-18 981 }, 04461a7e89447de3 Steen Hegelund 2022-10-18 982 [VCAP_KFS_IP4_TCP_UDP] = { 04461a7e89447de3 Steen Hegelund 2022-10-18 983 .type_id = 4, 04461a7e89447de3 Steen Hegelund 2022-10-18 984 .sw_per_item = 6, 04461a7e89447de3 Steen Hegelund 2022-10-18 985 .sw_cnt = 2, 04461a7e89447de3 Steen Hegelund 2022-10-18 986 }, 04461a7e89447de3 Steen Hegelund 2022-10-18 987 [VCAP_KFS_IP4_OTHER] = { 04461a7e89447de3 Steen Hegelund 2022-10-18 988 .type_id = 5, 04461a7e89447de3 Steen Hegelund 2022-10-18 989 .sw_per_item = 6, 04461a7e89447de3 Steen Hegelund 2022-10-18 990 .sw_cnt = 2, 04461a7e89447de3 Steen Hegelund 2022-10-18 991 }, 04461a7e89447de3 Steen Hegelund 2022-10-18 @992 [VCAP_KFS_IP6_STD] = { 04461a7e89447de3 Steen Hegelund 2022-10-18 993 .type_id = 6, 04461a7e89447de3 Steen Hegelund 2022-10-18 994 .sw_per_item = 6, 04461a7e89447de3 Steen Hegelund 2022-10-18 995 .sw_cnt = 2, 04461a7e89447de3 Steen Hegelund 2022-10-18 996 }, 04461a7e89447de3 Steen Hegelund 2022-10-18 997 [VCAP_KFS_IP_7TUPLE] = { 04461a7e89447de3 Steen Hegelund 2022-10-18 998 .type_id = 1, 04461a7e89447de3 Steen Hegelund 2022-10-18 999 .sw_per_item = 12, 04461a7e89447de3 Steen Hegelund 2022-10-18 1000 .sw_cnt = 1, 04461a7e89447de3 Steen Hegelund 2022-10-18 1001 }, 04461a7e89447de3 Steen Hegelund 2022-10-18 1002 }; 04461a7e89447de3 Steen Hegelund 2022-10-18 1003 -- 0-DAY CI Kernel Test Service https://01.org/lkp