mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Song Liu" <song@kernel.org>, "Dirk Müller" <dmueller@suse.de>,
	"Paul Menzel" <pmenzel@molgen.mpg.de>,
	"Giulio Benetti" <giulio.benetti@benettiengineering.com>,
	"Christoph Hellwig" <hch@infradead.org>
Subject: [PATCH] lib/raid6: drop RAID6_USE_EMPTY_ZERO_PAGE
Date: Wed, 19 Oct 2022 18:04:07 +0200	[thread overview]
Message-ID: <20221019160407.7550-1-giulio.benetti@benettiengineering.com> (raw)
In-Reply-To: <Y0/Yt4uJWg4knNoc@infradead.org>

RAID6_USE_EMPTY_ZERO_PAGE is unused and hardcoded to 0, so let's drop it.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 include/linux/raid/pq.h | 8 --------
 lib/raid6/algos.c       | 2 --
 2 files changed, 10 deletions(-)

diff --git a/include/linux/raid/pq.h b/include/linux/raid/pq.h
index d6e5a1feb947..f29aaaf2eb21 100644
--- a/include/linux/raid/pq.h
+++ b/include/linux/raid/pq.h
@@ -10,17 +10,9 @@
 
 #ifdef __KERNEL__
 
-/* Set to 1 to use kernel-wide empty_zero_page */
-#define RAID6_USE_EMPTY_ZERO_PAGE 0
 #include <linux/blkdev.h>
 
-/* We need a pre-zeroed page... if we don't want to use the kernel-provided
-   one define it here */
-#if RAID6_USE_EMPTY_ZERO_PAGE
-# define raid6_empty_zero_page empty_zero_page
-#else
 extern const char raid6_empty_zero_page[PAGE_SIZE];
-#endif
 
 #else /* ! __KERNEL__ */
 /* Used for testing in user space */
diff --git a/lib/raid6/algos.c b/lib/raid6/algos.c
index 39b74221f4a7..a22a05c9af8a 100644
--- a/lib/raid6/algos.c
+++ b/lib/raid6/algos.c
@@ -18,12 +18,10 @@
 #else
 #include <linux/module.h>
 #include <linux/gfp.h>
-#if !RAID6_USE_EMPTY_ZERO_PAGE
 /* In .bss so it's zeroed */
 const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(256)));
 EXPORT_SYMBOL(raid6_empty_zero_page);
 #endif
-#endif
 
 struct raid6_calls raid6_call;
 EXPORT_SYMBOL_GPL(raid6_call);
-- 
2.34.1


  parent reply	other threads:[~2022-10-19 16:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 21:57 [PATCH 1/3] ACPI: scan: substitute empty_zero_page with helper ZERO_PAGE(0) Giulio Benetti
2022-10-18 21:57 ` [PATCH 2/3] spi: fsl-cpm: " Giulio Benetti
2022-10-18 21:57 ` [PATCH 3/3] raid: " Giulio Benetti
2022-10-19 11:00   ` Christoph Hellwig
2022-10-19 13:19     ` Giulio Benetti
2022-10-19 16:04     ` Giulio Benetti [this message]
2022-10-19 16:10       ` [PATCH] lib/raid6: drop RAID6_USE_EMPTY_ZERO_PAGE Christoph Hellwig
2022-10-20 18:21         ` Song Liu
2022-10-19 16:12     ` [PATCH 3/3] raid: substitute empty_zero_page with helper ZERO_PAGE(0) Giulio Benetti
2022-10-19 14:56 ` (subset) [PATCH 1/3] ACPI: scan: " Mark Brown
2022-11-03 18:53 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221019160407.7550-1-giulio.benetti@benettiengineering.com \
    --to=giulio.benetti@benettiengineering.com \
    --cc=dmueller@suse.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome