From: Mario Limonciello <mario.limonciello@amd.com>
To: <mario.limonciello@amd.com>, Hans de Goede <hdegoede@redhat.com>,
<platform-driver-x86@vger.kernel.org>
Cc: Anson Tsao <anson.tsao@amd.com>,
You-Sheng Yang <vicamo.yang@canonical.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 0/1] Fix using rtcwake on Cezanne platforms
Date: Thu, 20 Oct 2022 06:37:48 -0500 [thread overview]
Message-ID: <20221020113749.6621-1-mario.limonciello@amd.com> (raw)
Vicamo reports that rtcwake is not working properly on 6.0 kernel, but
worked properly on 5.17 kernel. He bisected it down to:
commit b0c07116c8943 ("platform/x86: amd-pmc: Avoid reading SMU version at
probe time")
The issue is that commit made it possible to issue a suspend where SMU
version isn't known, meaning amd-pmc can't decide whether to activate
behavior to add a timer value to the OS_HINT message.
This wasn't reproduced on AMD's side initially because the testing
scripts were reading the idle mask from debugfs which would cache the
value in the driver.
This patch ensures that SMU version has been read even if debugfs hasn't
been accessed so that rtcwake can work again.
Mario Limonciello (1):
platform/x86/amd: pmc: Read SMU version during suspend on Cezanne
systems
drivers/platform/x86/amd/pmc.c | 7 +++++++
1 file changed, 7 insertions(+)
--
2.34.1
next reply other threads:[~2022-10-20 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 11:37 Mario Limonciello [this message]
2022-10-20 11:37 ` [PATCH 1/1] platform/x86/amd: pmc: Read SMU version during suspend on Cezanne systems Mario Limonciello
2022-10-24 9:29 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020113749.6621-1-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=anson.tsao@amd.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vicamo.yang@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®