From: Steven Rostedt <rostedt@goodmis.org>
To: chensong <chensong_2000@189.cn>
Cc: mingo@redhat.com, mhiramat@kernel.org,
linux-kernel@vger.kernel.org, xiehuan09@gmail.com
Subject: Re: [PATCH] trace/ring_buffer: remove unused arguments
Date: Thu, 20 Oct 2022 11:43:48 -0400 [thread overview]
Message-ID: <20221020114348.40fe9644@gandalf.local.home> (raw)
In-Reply-To: <e3547bc8-3acf-187c-1671-f5274112d01c@189.cn>
On Thu, 20 Oct 2022 23:25:56 +0800
chensong <chensong_2000@189.cn> wrote:
> > I guess this doesn't hurt.
>
> I was reading __kprobe_trace_func, store_trace_args stores args in
> fbuffer.entry,which is event->array, but at the end, rb_commit uses
> fbuffer.buffer instead of event.
>
> Then i thought, if it's useless, why not just clean it up.
I meant your change probably doesn't hurt.
-- Steve
prev parent reply other threads:[~2022-10-20 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 14:06 Song Chen
2022-10-20 14:15 ` Steven Rostedt
2022-10-20 15:25 ` chensong
2022-10-20 15:43 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020114348.40fe9644@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=chensong_2000@189.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=xiehuan09@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®