mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Yingliang <yangyingliang@huawei.com>
To: <linux-kernel@vger.kernel.org>, <qemu-devel@nongnu.org>,
	<linux-f2fs-devel@lists.sourceforge.net>,
	<linux-erofs@lists.ozlabs.org>, <ocfs2-devel@oss.oracle.com>,
	<linux-mtd@lists.infradead.org>, <amd-gfx@lists.freedesktop.org>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
	<somlo@cmu.edu>, <mst@redhat.com>, <jaegeuk@kernel.org>,
	<chao@kernel.org>, <hsiangkao@linux.alibaba.com>,
	<huangjianan@oppo.com>, <mark@fasheh.com>, <jlbec@evilplan.org>,
	<joseph.qi@linux.alibaba.com>, <akpm@linux-foundation.org>,
	<alexander.deucher@amd.com>, <luben.tuikov@amd.com>,
	<richard@nod.at>, <liushixin2@huawei.com>
Subject: [PATCH 06/11] firmware: qemu_fw_cfg: fix possible memory leak in fw_cfg_build_symlink()
Date: Fri, 21 Oct 2022 10:20:57 +0800	[thread overview]
Message-ID: <20221021022102.2231464-7-yangyingliang@huawei.com> (raw)
In-Reply-To: <20221021022102.2231464-1-yangyingliang@huawei.com>

Inject fault while loading module, kset_register() may fail, if
it fails, but the refcount of kobject is not decreased to 0, the
name allocated in kobject_set_name() is leaked. To fix this by
calling kset_put(), so that name can be freed in callback function
kobject_cleanup() and 'subdir' is freed in kset_release().

unreferenced object 0xffff88810ad69050 (size 8):
  comm "swapper/0", pid 1, jiffies 4294677178 (age 38.812s)
  hex dump (first 8 bytes):
    65 74 63 00 81 88 ff ff                          etc.....
  backtrace:
    [<00000000a80c7bf1>] __kmalloc_node_track_caller+0x44/0x1b0
    [<000000003f0167c7>] kstrdup+0x3a/0x70
    [<0000000049336709>] kstrdup_const+0x41/0x60
    [<00000000175616e4>] kvasprintf_const+0xf5/0x180
    [<000000004bcc30f7>] kobject_set_name_vargs+0x56/0x150
    [<000000004b0251bd>] kobject_set_name+0xab/0xe0
    [<00000000700151fb>] fw_cfg_sysfs_probe+0xa5b/0x1320

Fixes: 246c46ebaeae ("firmware: create directory hierarchy for sysfs fw_cfg entries")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/firmware/qemu_fw_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index a69399a6b7c0..d036e69cabbb 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -544,7 +544,7 @@ static int fw_cfg_build_symlink(struct kset *dir,
 			}
 			ret = kset_register(subdir);
 			if (ret) {
-				kfree(subdir);
+				kset_put(subdir);
 				break;
 			}
 
-- 
2.25.1


  parent reply	other threads:[~2022-10-21  2:22 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21  2:20 [PATCH 00/11] fix memory leak while kset_register() fails Yang Yingliang
2022-10-21  2:20 ` [PATCH 01/11] kset: fix documentation for kset_register() Yang Yingliang
2022-10-21  5:34   ` Luben Tuikov
2022-10-21  8:05     ` Yang Yingliang
2022-10-21  8:16       ` Greg KH
2022-10-21  8:18       ` Luben Tuikov
2022-10-21  2:20 ` [PATCH 02/11] kset: add null pointer check in kset_put() Yang Yingliang
2022-10-21  2:20 ` [PATCH 03/11] bus: fix possible memory leak in bus_register() Yang Yingliang
2022-10-21  2:20 ` [PATCH 04/11] kobject: fix possible memory leak in kset_create_and_add() Yang Yingliang
2022-10-21  2:20 ` [PATCH 05/11] class: fix possible memory leak in __class_register() Yang Yingliang
2022-10-21  2:20 ` Yang Yingliang [this message]
2022-10-21  2:20 ` [PATCH 07/11] f2fs: fix possible memory leak in f2fs_init_sysfs() Yang Yingliang
2022-10-21  2:20 ` [PATCH 08/11] erofs: fix possible memory leak in erofs_init_sysfs() Yang Yingliang
2022-10-21  2:21 ` [PATCH 09/11] ocfs2: possible memory leak in mlog_sys_init() Yang Yingliang
2022-10-21  2:21 ` [PATCH 10/11] drm/amdgpu/discovery: fix possible memory leak Yang Yingliang
2022-10-21  2:21 ` [PATCH 11/11] ubifs: Fix memory leak in ubifs_sysfs_init() Yang Yingliang
2022-10-21  5:29 ` [PATCH 00/11] fix memory leak while kset_register() fails Luben Tuikov
2022-10-21  5:37   ` Greg KH
2022-10-21  7:55     ` Luben Tuikov
2022-10-21  8:18       ` Greg KH
2022-10-21  8:24         ` Luben Tuikov
2022-10-21  8:41           ` Luben Tuikov
2022-10-21  9:23             ` Yang Yingliang
2022-10-21  8:24     ` Yang Yingliang
2022-10-21  8:36       ` Greg KH
2022-10-21  8:52         ` Luben Tuikov
2022-10-21  8:59         ` Yang Yingliang
2022-10-21  9:08           ` Luben Tuikov
2022-10-21  9:56             ` Yang Yingliang
2022-10-21 23:45               ` Luben Tuikov
2022-10-21  9:12         ` Yang Yingliang
2022-10-21 23:48           ` Luben Tuikov
2022-10-21  7:25   ` Yang Yingliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221021022102.2231464-7-yangyingliang@huawei.com \
    --to=yangyingliang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chao@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=huangjianan@oppo.com \
    --cc=jaegeuk@kernel.org \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=liushixin2@huawei.com \
    --cc=luben.tuikov@amd.com \
    --cc=mark@fasheh.com \
    --cc=mst@redhat.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rafael@kernel.org \
    --cc=richard@nod.at \
    --cc=somlo@cmu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®