From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Luka Perkov <luka.perkov@sartura.hr>,
Robert Marko <robert.marko@sartura.hr>
Subject: [PATCH net-next v5 0/5] [PATCH net-next v4 0/5] net: ipqess: introduce Qualcomm IPQESS driver
Date: Fri, 21 Oct 2022 14:45:51 +0200 [thread overview]
Message-ID: <20221021124556.100445-1-maxime.chevallier@bootlin.com> (raw)
Hello everyone,
This is the 5th iteration of a series that introduces a new driver, for
the Qualcomm IPQESS Ethernet Controller, found on the IPQ4019.
Note that this series contains binding patches that should go through the
DT tree.
The notable aspect of this series is the introduction of an out-of-band
DSA tagger. While V1 used a custom set of sk_buff fields, and v2 to v4
used the headroom to convey the tag, this version uses skb extensions to
carry the tag.
This allows to easily identify that a skb conveys a tag or not, by
checking if the extension is here.
Other changes in the series were some rework of the napi polling loops,
and a few fixes suggested by Vlad, Andrew and Krzysztof.
Notables changes on V5 :
- Fix caching of CHANGEUPPER events
- Use a skb extension-based tagger
- Rename the binding file
- Some cleanups in the ipqess driver itself
Notables changes on V4 :
- Cache the uses_dsa info from CHANGEUPPER events
- Use better string handling helpers for ethtool stats
- rename ethtool callbacks
- Fix a binding typo
Notables changes on V3 :
- Took into account Russell's review on the ioctl handler and the mac
capabilities that were missing
- Took Andrew's reviews into account by reworking the napi rx loop,
some stray "inline" keywords, and useless warnings
- Took Vlad's reviews into account by reworking a few macros
- Took Christophe's review into account by removing extra GFP_ZERO
- Took Rob's review into account by simplifying the binding
Notables changes on V2 :
- Put the DSA tag in the skb itself instead of using skb->shinfo
- Fixed the initialisation sequence based on Andrew's comments
- Reworked the error paths in the init sequence
- Add support for the clock and reset lines on that controller
- Fixed and updated the binding
The driver itself is pretty straightforward, but has lived out-of-tree
for a while. I've done my best to clean-up some outdated API calls, but
some might remain.
This controller is somewhat special, since it's part of the IPQ4019 SoC
which also includes an QCA8K switch, and uses the IPQESS controller for
the CPU port. The switch is so tightly intergrated with the MAC that it
is connected to the MAC using an internal link (hence the fact that we
only support PHY_INTERFACE_MODE_INTERNAL), and this has some
consequences on the DSA side.
The tagging for the switch isn't done inband as most switch do, but
out-of-band, the DSA tag being included in the DMA descriptor.
This series includes a new out-of-band tagger that uses skb extensions
to convey the tag between the tagger and the MAC driver.
Thanks to the Sartura folks who worked on a base version of this driver,
and provided test hardware.
Best regards,
Maxime Chevallier
Maxime Chevallier (5):
net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller
net: ipqess: introduce the Qualcomm IPQESS driver
net: dsa: add out-of-band tagging protocol
net: ipqess: Add out-of-band DSA tagging support
ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet
controller
.../bindings/net/qcom,ipq4019-ess-edma.yaml | 95 ++
MAINTAINERS | 6 +
arch/arm/boot/dts/qcom-ipq4019.dtsi | 46 +
drivers/net/ethernet/qualcomm/Kconfig | 12 +
drivers/net/ethernet/qualcomm/Makefile | 2 +
drivers/net/ethernet/qualcomm/ipqess/Makefile | 8 +
drivers/net/ethernet/qualcomm/ipqess/ipqess.c | 1324 +++++++++++++++++
drivers/net/ethernet/qualcomm/ipqess/ipqess.h | 522 +++++++
.../ethernet/qualcomm/ipqess/ipqess_ethtool.c | 164 ++
include/linux/dsa/oob.h | 17 +
include/linux/skbuff.h | 3 +
include/net/dsa.h | 2 +
net/core/skbuff.c | 10 +
net/dsa/Kconfig | 8 +
net/dsa/Makefile | 1 +
net/dsa/tag_oob.c | 80 +
16 files changed, 2300 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq4019-ess-edma.yaml
create mode 100644 drivers/net/ethernet/qualcomm/ipqess/Makefile
create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess.c
create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess.h
create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess_ethtool.c
create mode 100644 include/linux/dsa/oob.h
create mode 100644 net/dsa/tag_oob.c
--
2.37.3
next reply other threads:[~2022-10-21 12:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 12:45 Maxime Chevallier [this message]
2022-10-21 12:45 ` [PATCH net-next v5 1/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Maxime Chevallier
2022-10-21 13:33 ` Krzysztof Kozlowski
2022-10-21 14:30 ` Vladimir Oltean
2022-10-21 14:53 ` Rob Herring
2022-10-21 12:45 ` [PATCH net-next v5 2/5] net: ipqess: introduce the Qualcomm IPQESS driver Maxime Chevallier
2022-10-21 13:38 ` Krzysztof Kozlowski
2022-10-21 14:39 ` Andrew Lunn
2022-10-21 17:49 ` kernel test robot
2022-10-21 17:59 ` kernel test robot
2022-10-21 12:45 ` [PATCH net-next v5 3/5] net: dsa: add out-of-band tagging protocol Maxime Chevallier
2022-10-21 14:01 ` Vladimir Oltean
2022-10-21 14:43 ` Andrew Lunn
2022-10-21 14:46 ` Andrew Lunn
2022-10-21 19:51 ` kernel test robot
2022-10-21 12:45 ` [PATCH net-next v5 4/5] net: ipqess: Add out-of-band DSA tagging support Maxime Chevallier
2022-10-21 14:12 ` Vladimir Oltean
2022-10-21 12:45 ` [PATCH net-next v5 5/5] ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controller Maxime Chevallier
2022-10-21 14:20 ` Vladimir Oltean
2022-10-21 14:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021124556.100445-1-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luka.perkov@sartura.hr \
--cc=netdev@vger.kernel.org \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®