From: Pavel Machek <pavel@ucw.cz>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] leds-pca955x: Remove the unused function pca95xx_num_led_regs()
Date: Fri, 21 Oct 2022 15:08:45 +0200 [thread overview]
Message-ID: <20221021130845.GA16264@duo.ucw.cz> (raw)
In-Reply-To: <20221017081053.52388-1-jiapeng.chong@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
Hi!
> The function pca95xx_num_led_regs() is defined in the leds-pca955x.c
> file, but not called elsewhere, so delete this unused function.
>
> drivers/leds/leds-pca955x.c:149:19: warning: unused function 'pca95xx_num_led_regs'.
Thank you, applied.
Best regards,
Pavel
> +++ b/drivers/leds/leds-pca955x.c
> @@ -145,12 +145,6 @@ static inline int pca95xx_num_input_regs(int bits)
> return (bits + 7) / 8;
> }
>
> -/* 4 bits per LED selector register */
> -static inline int pca95xx_num_led_regs(int bits)
> -{
> - return (bits + 3) / 4;
> -}
> -
> /*
> * Return an LED selector register value based on an existing one, with
> * the appropriate 2-bit state value set for the given LED number (0-3).
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2022-10-21 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 8:10 Jiapeng Chong
2022-10-21 13:08 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021130845.GA16264@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®