From: Rick Edgecombe <rick.p.edgecombe@intel.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, rick.p.edgecombe@intel.com,
keescook@chromium.org, ebiederm@xmission.com
Subject: [PATCH 0/2] Regset cleanups
Date: Fri, 21 Oct 2022 15:18:01 -0700 [thread overview]
Message-ID: <20221021221803.10910-1-rick.p.edgecombe@intel.com> (raw)
These two cleanups came out of the shadow stack series[0]. Resending them
separately for earlier consideration. They were also posted as separate
cleanups once before[1]. Note, Eric Biederman had suggested to change the
pre-existing format of REGSET_FOO32 to REGSET32_FOO. This was missed in an
earlier revision, and the changes are now added in this version.
There should be no functional change. To verify this, testing included checking
for binary differences in ptrace.o by:
1. Have the config be a 64 bit kernel with CONFIG_IA32_EMULATION=y
2. Adjust stock v6.1-rc1 and these changes to have the same line numbers for
the bulk of the code in ptrace.c by adding blank lines.
3. Remove BUILD_BUG_ONs() from new changes.
4. strip and objdump both versions.
5. Compare and find disassembly was identical.
[0] https://lore.kernel.org/lkml/20220929222936.14584-1-rick.p.edgecombe@intel.com/
[1] https://lore.kernel.org/lkml/20220315201706.7576-1-rick.p.edgecombe@intel.com/
Rick Edgecombe (2):
x86: Separate out x86_regset for 32 and 64 bit
x86: Improve formatting of user_regset arrays
arch/x86/kernel/ptrace.c | 174 ++++++++++++++++++++++++---------------
1 file changed, 108 insertions(+), 66 deletions(-)
base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780
--
2.17.1
next reply other threads:[~2022-10-21 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 22:18 Rick Edgecombe [this message]
2022-10-21 22:18 ` [PATCH 1/2] x86: Separate out x86_regset for 32 and 64 bit Rick Edgecombe
2022-10-21 23:55 ` Kees Cook
2022-10-21 22:18 ` [PATCH 2/2] x86: Improve formatting of user_regset arrays Rick Edgecombe
2022-10-21 23:56 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021221803.10910-1-rick.p.edgecombe@intel.com \
--to=rick.p.edgecombe@intel.com \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®