From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E2317C38A2D
	for <linux-kernel@archiver.kernel.org>; Mon, 24 Oct 2022 22:51:16 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229993AbiJXWvO (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 24 Oct 2022 18:51:14 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33580 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232136AbiJXWum (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Oct 2022 18:50:42 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF6533200D3
        for <linux-kernel@vger.kernel.org>; Mon, 24 Oct 2022 14:12:40 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 38214B810F4
        for <linux-kernel@vger.kernel.org>; Mon, 24 Oct 2022 20:17:09 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8445BC433C1;
        Mon, 24 Oct 2022 20:17:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
        s=korg; t=1666642627;
        bh=pve3Synlkj6J6i7lSu93YkYeZZdRndbv6uz1vAXSx90=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=T9EjYDwM/Ae7QhYWk18ZfQDUShXZj2tVAmRUMcw7GCIYWfPXvfAXhbguwEBsrXhI0
         wsPM4qqXR81KWcOnxi51u0M+n6TRWkT3CGpttzRr8GtnOQHCzepzyWs60+otFFcc0p
         rjuz3SxOcz13igJ8VDFOBVeN0YX1DNxMpflHP9mo=
Date:   Mon, 24 Oct 2022 13:17:06 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Gautam Menghani <gautammenghani201@gmail.com>
Cc:     rostedt@goodmis.org, mhiramat@kernel.org, zokeefe@google.com,
        shy828301@gmail.com, vbabka@suse.cz, david@redhat.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v2] mm/khugepaged: add tracepoint to collapse_file()
Message-Id: <20221024131706.3d58bd92c332684386c7df13@linux-foundation.org>
In-Reply-To: <20221024173559.332324-1-gautammenghani201@gmail.com>
References: <20221024173559.332324-1-gautammenghani201@gmail.com>
X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 24 Oct 2022 23:05:58 +0530 Gautam Menghani <gautammenghani201@gmail.com> wrote:

> In the file mm/khugepaged.c, a TODO in the function collapse_file() asks
> to add tracepoints. Add the tracepoint named "mm_khugepaged_collapse_file".

This isn't a very satisfying explanation for changing the kernel.  Maybe
the comment is stale are this tracepoint is unneeded.

Please explain afresh how this addition benefits kernel users?