From: "Paul E. McKenney" <paulmck@kernel.org>
To: torvalds@linux-foundation.org
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, rcu@vger.kernel.org, kernel-team@fb.com,
rostedt@goodmis.org
Subject: [GIT PULL] Keep synchronize_rcu() from enabling irqs in early boot
Date: Mon, 24 Oct 2022 09:54:21 -0700 [thread overview]
Message-ID: <20221024165421.GA1246679@paulmck-ThinkPad-P17-Gen-1> (raw)
Hello, Linus,
This pull request fixes a merge-window regression noted by Steve Rostedt.
The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780:
Linux 6.1-rc1 (2022-10-16 15:36:24 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git tags/rcu-urgent.2022.10.20a
for you to fetch changes up to 31d8aaa87fcef1be5932f3813ea369e21bd3b11d:
rcu: Keep synchronize_rcu() from enabling irqs in early boot (2022-10-20 15:34:49 -0700)
----------------------------------------------------------------
Urgent RCU pull request for v6.1
This pull request contains a commit that fixes bf95b2bc3e42 ("rcu: Switch
polled grace-period APIs to ->gp_seq_polled"), which could incorrectly
leave interrupts enabled after an early-boot call to synchronize_rcu().
Such synchronize_rcu() calls must acquire leaf rcu_node locks in order to
properly interact with polled grace periods, but the code did not take
into account the possibility of synchronize_rcu() being invoked from
the portion of the boot sequence during which interrupts are disabled.
This commit therefore switches the lock acquisition and release from
irq to irqsave/irqrestore.
----------------------------------------------------------------
Paul E. McKenney (1):
rcu: Keep synchronize_rcu() from enabling irqs in early boot
kernel/rcu/tree.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
next reply other threads:[~2022-10-24 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:54 Paul E. McKenney [this message]
2022-10-24 19:40 ` Linus Torvalds
2022-10-24 20:04 ` Paul E. McKenney
2022-10-24 20:06 ` Linus Torvalds
2022-10-24 20:21 ` Paul E. McKenney
2022-10-24 20:06 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024165421.GA1246679@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®