From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Joerg Roedel <joro@8bytes.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: remove variable cnt
Date: Mon, 24 Oct 2022 13:33:42 -0700 [thread overview]
Message-ID: <20221024203342.nbmqphmfbrqqtr4n@cantor> (raw)
In-Reply-To: <20221024134301.2158939-1-colin.i.king@gmail.com>
On Mon, Oct 24, 2022 at 02:43:01PM +0100, Colin Ian King wrote:
> Variable cnt is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/iommu/amd/iommu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index d3b39d0416fa..3847f3bdc568 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -767,7 +767,7 @@ EXPORT_SYMBOL(amd_iommu_register_ga_log_notifier);
>
> static void iommu_poll_ga_log(struct amd_iommu *iommu)
> {
> - u32 head, tail, cnt = 0;
> + u32 head, tail;
>
> if (iommu->ga_log == NULL)
> return;
> @@ -780,7 +780,6 @@ static void iommu_poll_ga_log(struct amd_iommu *iommu)
> u64 log_entry;
>
> raw = (u64 *)(iommu->ga_log + head);
> - cnt++;
>
> /* Avoid memcpy function-call overhead */
> log_entry = *raw;
> --
> 2.37.3
>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
next prev parent reply other threads:[~2022-10-24 23:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 13:43 Colin Ian King
2022-10-24 20:33 ` Jerry Snitselaar [this message]
2022-10-25 10:56 ` Vasant Hegde
2022-11-03 14:40 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024203342.nbmqphmfbrqqtr4n@cantor \
--to=jsnitsel@redhat.com \
--cc=colin.i.king@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®