mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
To: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <krzysztof.kozlowski@linaro.org>
Cc: <bhelgaas@google.com>, <michals@xilinx.com>, <robh+dt@kernel.org>,
	<lorenzo.pieralisi@arm.com>, <bharat.kumar.gogada@amd.com>,
	"Thippeswamy Havalige" <thippeswamy.havalige@amd.com>
Subject: [PATCH 01/13] microblaze/PCI: Remove unused early_read_config_byte() et al declarations
Date: Tue, 25 Oct 2022 12:22:02 +0530	[thread overview]
Message-ID: <20221025065214.4663-2-thippeswamy.havalige@amd.com> (raw)
In-Reply-To: <20221025065214.4663-1-thippeswamy.havalige@amd.com>

early_read_config_byte() and similar are declared but never defined.

Remove the unused declarations.

Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
---
 arch/microblaze/include/asm/pci-bridge.h | 18 ------------
 arch/microblaze/pci/pci-common.c         |  5 ----
 arch/microblaze/pci/xilinx_pci.c         | 48 --------------------------------
 3 files changed, 71 deletions(-)

diff --git a/arch/microblaze/include/asm/pci-bridge.h b/arch/microblaze/include/asm/pci-bridge.h
index 171b40a..a9d3940 100644
--- a/arch/microblaze/include/asm/pci-bridge.h
+++ b/arch/microblaze/include/asm/pci-bridge.h
@@ -103,24 +103,6 @@ static inline int isa_vaddr_is_ioport(void __iomem *address)
 }
 #endif /* CONFIG_PCI */
 
-/* These are used for config access before all the PCI probing
-   has been done. */
-extern int early_read_config_byte(struct pci_controller *hose, int bus,
-			int dev_fn, int where, u8 *val);
-extern int early_read_config_word(struct pci_controller *hose, int bus,
-			int dev_fn, int where, u16 *val);
-extern int early_read_config_dword(struct pci_controller *hose, int bus,
-			int dev_fn, int where, u32 *val);
-extern int early_write_config_byte(struct pci_controller *hose, int bus,
-			int dev_fn, int where, u8 val);
-extern int early_write_config_word(struct pci_controller *hose, int bus,
-			int dev_fn, int where, u16 val);
-extern int early_write_config_dword(struct pci_controller *hose, int bus,
-			int dev_fn, int where, u32 val);
-
-extern int early_find_capability(struct pci_controller *hose, int bus,
-				 int dev_fn, int cap);
-
 extern void setup_indirect_pci(struct pci_controller *hose,
 			       resource_size_t cfg_addr,
 			       resource_size_t cfg_data, u32 flags);
diff --git a/arch/microblaze/pci/pci-common.c b/arch/microblaze/pci/pci-common.c
index 33bab7e..69ce51c 100644
--- a/arch/microblaze/pci/pci-common.c
+++ b/arch/microblaze/pci/pci-common.c
@@ -1060,8 +1060,3 @@ long sys_pciconfig_iobase(long which, unsigned long bus, unsigned long devfn)
 EARLY_PCI_OP(write, word, u16)
 EARLY_PCI_OP(write, dword, u32)
 
-int early_find_capability(struct pci_controller *hose, int bus, int devfn,
-			  int cap)
-{
-	return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
-}
diff --git a/arch/microblaze/pci/xilinx_pci.c b/arch/microblaze/pci/xilinx_pci.c
index f4cb86f..7ed6647 100644
--- a/arch/microblaze/pci/xilinx_pci.c
+++ b/arch/microblaze/pci/xilinx_pci.c
@@ -76,44 +76,6 @@ static void xilinx_pci_fixup_bridge(struct pci_dev *dev)
 {
 	return (bus != 0);
 }
-
-/**
- * xilinx_early_pci_scan - List pci config space for available devices
- *
- * List pci devices in very early phase.
- */
-static void __init xilinx_early_pci_scan(struct pci_controller *hose)
-{
-	u32 bus = 0;
-	u32 val, dev, func, offset;
-
-	/* Currently we have only 2 device connected - up-to 32 devices */
-	for (dev = 0; dev < 2; dev++) {
-		/* List only first function number - up-to 8 functions */
-		for (func = 0; func < 1; func++) {
-			pr_info("%02x:%02x:%02x", bus, dev, func);
-			/* read the first 64 standardized bytes */
-			/* Up-to 192 bytes can be list of capabilities */
-			for (offset = 0; offset < 64; offset += 4) {
-				early_read_config_dword(hose, bus,
-					PCI_DEVFN(dev, func), offset, &val);
-				if (offset == 0 && val == 0xFFFFFFFF) {
-					pr_cont("\nABSENT");
-					break;
-				}
-				if (!(offset % 0x10))
-					pr_cont("\n%04x:    ", offset);
-
-				pr_cont("%08x  ", val);
-			}
-			pr_info("\n");
-		}
-	}
-}
-#else
-static void __init xilinx_early_pci_scan(struct pci_controller *hose)
-{
-}
 #endif
 
 /**
@@ -146,15 +108,6 @@ void __init xilinx_pci_init(void)
 			   r.start + XPLB_PCI_DATA,
 			   INDIRECT_TYPE_SET_CFG_TYPE);
 
-	/* According to the xilinx plbv46_pci documentation the soft-core starts
-	 * a self-init when the bus master enable bit is set. Without this bit
-	 * set the pci bus can't be scanned.
-	 */
-	early_write_config_word(hose, 0, 0, PCI_COMMAND, PCI_HOST_ENABLE_CMD);
-
-	/* Set the max latency timer to 255 */
-	early_write_config_byte(hose, 0, 0, PCI_LATENCY_TIMER, 0xff);
-
 	/* Set the max bus number to 255, and bus/subbus no's to 0 */
 	pci_reg = of_iomap(pci_node, 0);
 	WARN_ON(!pci_reg);
@@ -166,5 +119,4 @@ void __init xilinx_pci_init(void)
 					INDIRECT_TYPE_SET_CFG_TYPE);
 
 	pr_info("xilinx-pci: Registered PCI host bridge\n");
-	xilinx_early_pci_scan(hose);
 }
-- 
1.8.3.1


  reply	other threads:[~2022-10-25  6:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25  6:52 [PATCH 00/13] Remove unused microblaze PCIe bus architecture Thippeswamy Havalige
2022-10-25  6:52 ` Thippeswamy Havalige [this message]
2022-10-25  6:52 ` [PATCH 02/13] microblaze/PCI: Remove Null PCI config access unused functions Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 03/13] microblaze/PCI: Remove unused PCI bus scan if configured as a host Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 04/13] microblaze/PCI: Remove unused PCI legacy IO's access on a bus Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 05/13] microblaze/PCI: Remove unused device tree parsing for a host bridge resources Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 06/13] microblaze/PCI: Remove unused allocation & free of PCI host bridge structure Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 07/13] microblaze/PCI: Remove unused PCI BIOS resource allocation Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 08/13] microblaze/PCI: Remove unused PCI Indirect ops Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 09/13] microblaze/PCI: Remove unused pci_address_to_pio() conversion of CPU address to I/O port Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 10/13] microblaze/PCI: Remove unused sys_pciconfig_iobase() and et al declaration Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 11/13] microblaze/PCI: Remove unused pci_iobar_pfn() and et al declarations Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 12/13] microblaze/PCI: Remove support for Xilinx PCI host bridge Thippeswamy Havalige
2022-10-25  6:52 ` [PATCH 13/13] microblaze/PCI: Moving PCI iounmap and dependent code Thippeswamy Havalige
2022-10-25  7:31 ` [PATCH 00/13] Remove unused microblaze PCIe bus architecture Michal Simek
2022-10-25  8:26   ` Havalige, Thippeswamy
2022-10-25  9:22     ` Michal Simek
2022-10-25 14:07       ` Havalige, Thippeswamy
2022-10-27  9:46   ` Lorenzo Pieralisi
2022-11-04  8:56     ` Havalige, Thippeswamy
2022-11-25 10:39 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221025065214.4663-2-thippeswamy.havalige@amd.com \
    --to=thippeswamy.havalige@amd.com \
    --cc=bharat.kumar.gogada@amd.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=michals@xilinx.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®