From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD1DFA373E for ; Tue, 25 Oct 2022 08:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232221AbiJYIX5 (ORCPT ); Tue, 25 Oct 2022 04:23:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230214AbiJYIX4 (ORCPT ); Tue, 25 Oct 2022 04:23:56 -0400 Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A9D1F9710; Tue, 25 Oct 2022 01:23:54 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id CD49720571; Tue, 25 Oct 2022 10:23:51 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rumSf-F5yxFL; Tue, 25 Oct 2022 10:23:51 +0200 (CEST) Received: from mailout1.secunet.com (mailout1.secunet.com [62.96.220.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 5FB562053B; Tue, 25 Oct 2022 10:23:51 +0200 (CEST) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout1.secunet.com (Postfix) with ESMTP id 4FB2B80004A; Tue, 25 Oct 2022 10:23:51 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct 2022 10:23:51 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 25 Oct 2022 10:23:50 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 5CB843180D2B; Tue, 25 Oct 2022 10:23:50 +0200 (CEST) Date: Tue, 25 Oct 2022 10:23:50 +0200 From: Steffen Klassert To: Colin Ian King CC: Herbert Xu , "David S . Miller" , Hideaki YOSHIFUJI , "David Ahern" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , , , Subject: Re: [PATCH] esp6: remove redundant variable err Message-ID: <20221025082350.GR2602992@gauss3.secunet.de> References: <20221017220809.864495-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221017220809.864495-1-colin.i.king@gmail.com> X-ClientProxiedBy: cas-essen-02.secunet.de (10.53.40.202) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2022 at 11:08:09PM +0100, Colin Ian King wrote: > Variable err is being assigned a value that is not read, the assignment > is redundant and so is the variable. Remove it. > > Cleans up clang scan warning: > net/ipv6/esp6_offload.c:64:7: warning: Although the value stored to 'err' > is used in the enclosing expression, the value is never actually read > from 'err' [deadcode.DeadStores] > > Signed-off-by: Colin Ian King Applied to ipsec-next, thanks!