Hi Jason, I love your patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on crng-random/master soc/for-next linus/master v6.1-rc2 next-20221024] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jason-A-Donenfeld/misc-sgi-gru-use-explicitly-signed-char/20221025-031949 patch link: https://lore.kernel.org/r/20221024162823.535884-1-Jason%40zx2c4.com patch subject: [PATCH] misc: sgi-gru: use explicitly signed char config: x86_64-rhel-8.3-kunit compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/98004b57afa345d7719be46c894cc07e7731df11 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jason-A-Donenfeld/misc-sgi-gru-use-explicitly-signed-char/20221025-031949 git checkout 98004b57afa345d7719be46c894cc07e7731df11 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/misc/sgi-gru/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/misc/sgi-gru/grumain.c:172:15: error: conflicting types for 'gru_reserve_cb_resources'; have 'long unsigned int(struct gru_state *, int, signed char *)' 172 | unsigned long gru_reserve_cb_resources(struct gru_state *gru, int cbr_au_count, | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/misc/sgi-gru/grumain.c:21: drivers/misc/sgi-gru/grutables.h:645:22: note: previous declaration of 'gru_reserve_cb_resources' with type 'long unsigned int(struct gru_state *, int, char *)' 645 | extern unsigned long gru_reserve_cb_resources(struct gru_state *gru, | ^~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/misc/sgi-gru/grumain.c:179:15: error: conflicting types for 'gru_reserve_ds_resources'; have 'long unsigned int(struct gru_state *, int, signed char *)' 179 | unsigned long gru_reserve_ds_resources(struct gru_state *gru, int dsr_au_count, | ^~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/misc/sgi-gru/grumain.c:21: drivers/misc/sgi-gru/grutables.h:647:22: note: previous declaration of 'gru_reserve_ds_resources' with type 'long unsigned int(struct gru_state *, int, char *)' 647 | extern unsigned long gru_reserve_ds_resources(struct gru_state *gru, | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +172 drivers/misc/sgi-gru/grumain.c 9a0deecc90de62 Jack Steiner 2008-07-29 171 9ca8e40c130c90 Jack Steiner 2008-07-29 @172 unsigned long gru_reserve_cb_resources(struct gru_state *gru, int cbr_au_count, 98004b57afa345 Jason A. Donenfeld 2022-10-24 173 signed char *cbmap) 9a0deecc90de62 Jack Steiner 2008-07-29 174 { 9a0deecc90de62 Jack Steiner 2008-07-29 175 return reserve_resources(&gru->gs_cbr_map, cbr_au_count, GRU_CBR_AU, 9a0deecc90de62 Jack Steiner 2008-07-29 176 cbmap); 9a0deecc90de62 Jack Steiner 2008-07-29 177 } 9a0deecc90de62 Jack Steiner 2008-07-29 178 9ca8e40c130c90 Jack Steiner 2008-07-29 @179 unsigned long gru_reserve_ds_resources(struct gru_state *gru, int dsr_au_count, 98004b57afa345 Jason A. Donenfeld 2022-10-24 180 signed char *dsmap) 9a0deecc90de62 Jack Steiner 2008-07-29 181 { 9a0deecc90de62 Jack Steiner 2008-07-29 182 return reserve_resources(&gru->gs_dsr_map, dsr_au_count, GRU_DSR_AU, 9a0deecc90de62 Jack Steiner 2008-07-29 183 dsmap); 9a0deecc90de62 Jack Steiner 2008-07-29 184 } 9a0deecc90de62 Jack Steiner 2008-07-29 185 -- 0-DAY CI Kernel Test Service https://01.org/lkp