From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Rafael Mendonca <rafaelmendsr@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Alexei Starovoitov <ast@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fprobe: Check rethook_alloc() return in rethook initialization
Date: Tue, 25 Oct 2022 17:03:46 +0900 [thread overview]
Message-ID: <20221025170346.2fbd0158e98882dd09812431@kernel.org> (raw)
In-Reply-To: <20221025031209.954836-1-rafaelmendsr@gmail.com>
On Tue, 25 Oct 2022 00:12:08 -0300
Rafael Mendonca <rafaelmendsr@gmail.com> wrote:
> Check if fp->rethook succeeded to be allocated. Otherwise, if
> rethook_alloc() fails, then we end up dereferencing a NULL pointer in
> rethook_add_node().
Good catch!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thank you!
>
> Fixes: 5b0ab78998e3 ("fprobe: Add exit_handler support")
> Signed-off-by: Rafael Mendonca <rafaelmendsr@gmail.com>
> ---
> kernel/trace/fprobe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/trace/fprobe.c b/kernel/trace/fprobe.c
> index aac63ca9c3d1..71614b2a67ff 100644
> --- a/kernel/trace/fprobe.c
> +++ b/kernel/trace/fprobe.c
> @@ -141,6 +141,8 @@ static int fprobe_init_rethook(struct fprobe *fp, int num)
> return -E2BIG;
>
> fp->rethook = rethook_alloc((void *)fp, fprobe_exit_handler);
> + if (!fp->rethook)
> + return -ENOMEM;
> for (i = 0; i < size; i++) {
> struct fprobe_rethook_node *node;
>
> --
> 2.34.1
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2022-10-25 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 3:12 Rafael Mendonca
2022-10-25 8:03 ` Masami Hiramatsu [this message]
2022-10-25 11:47 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025170346.2fbd0158e98882dd09812431@kernel.org \
--to=mhiramat@kernel.org \
--cc=ast@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafaelmendsr@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®