From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F8DFA373E for ; Tue, 25 Oct 2022 19:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232284AbiJYTmX (ORCPT ); Tue, 25 Oct 2022 15:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232208AbiJYTmS (ORCPT ); Tue, 25 Oct 2022 15:42:18 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 586748C448; Tue, 25 Oct 2022 12:42:17 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 29PJg2MZ119572; Tue, 25 Oct 2022 14:42:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1666726922; bh=H/as/1Tn9o1i2U2DwmPl0CGI3P3tgiJdJ3deInJ3bw0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=Er6+biu5OoiqIuFs74X+1JBEm08eYptQuWK8UBFebRFe6bIZ1L4SDUNL13nlRFtGa vBIsiDuCbkfVT3dhdCSLmg6TjWgJE2KAaJJvfRbI7t2uVOSnC/tm7H5jgux8+TuYc0 auGAs2disOnVah1ZKlLcyrqSJ1bF1hg4OxpHgAo8= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 29PJg2PJ079385 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Oct 2022 14:42:02 -0500 Received: from DFLE112.ent.ti.com (10.64.6.33) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6; Tue, 25 Oct 2022 14:42:01 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.6 via Frontend Transport; Tue, 25 Oct 2022 14:42:02 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 29PJg1kL027737; Tue, 25 Oct 2022 14:42:01 -0500 Date: Tue, 25 Oct 2022 14:42:01 -0500 From: Bryan Brattlof To: "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Vignesh Raghavendra , Tero Kristo CC: Keerthy , Linux PM , Device Trees , LKML , LKML ARM Subject: Re: [PATCH v2 04/11] thermal: k3_j72xx_bandgap: map fuse_base only for erratum workaround Message-ID: <20221025194201.3iup4ionv3zhnfd5@bryanbrattlof.com> References: <20221025191515.9151-1-bb@ti.com> <20221025191515.9151-5-bb@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20221025191515.9151-5-bb@ti.com> X-PGP-Fingerprint: D3D1 77E4 0A38 DF4D 1853 FEEF 41B9 0D5D 71D5 6CE0 User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On October 25, 2022 thus sayeth Bryan Brattlof: > Some of TI's J721E SoCs require a software trimming procedure for the > temperature monitors to function properly. To determine if a particular > J721E is not affected by this erratum, both bits in the WKUP_SPARE_FUSE0 > region must be set. Other SoCs, not affected by this erratum, will not > need this region. > > Map the 'fuse_base' region only when the erratum fix is needed. > > Signed-off-by: Bryan Brattlof > --- > drivers/thermal/k3_j72xx_bandgap.c | 37 ++++++++++++++++++------------ > 1 file changed, 22 insertions(+), 15 deletions(-) > ... > > - if (workaround_needed) > - devm_iounmap(dev, fuse_base); > - Ugh... This is wrong. Of course I will catch it right after I send this out Sorry for the noise everyone ~Bryan