From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E754C38A2D for ; Wed, 26 Oct 2022 13:58:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234139AbiJZN6m (ORCPT ); Wed, 26 Oct 2022 09:58:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234143AbiJZN5v (ORCPT ); Wed, 26 Oct 2022 09:57:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA1E0DB9 for ; Wed, 26 Oct 2022 06:57:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7700CB82256 for ; Wed, 26 Oct 2022 13:57:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2473BC433D6; Wed, 26 Oct 2022 13:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666792664; bh=t4btE/+qdMMC0jKvmw5NCgtrdHE2HNaZB5p9dfo+HMU=; h=From:To:Cc:Subject:Date:From; b=YrVxNDdhLRgt4PR45aJuqDkjiIqL+57Y58mohI/g8KvpTf8IyUPI5yjThSO51OBiy xhm6vtccUlGArHk977rZkB3+FZ9seglvIOZDyJIZM7pOChdqAkDr75kaL/NqkBnYoy 6SCefp9HcxJCW7R/yfDY/SF/ATwkefo4lttt4OJhVxxFgOFeB1ydwfPTPLQCplF2OL 3bLWapzQrWoyKubZxG03hlXOOqI5AUDlY6s1IXQ3XNfvnSoxYJG59TbZ8+LUFLYQPw QolQN/SQJffGfiE4t6f0Qsqu7hcGQzN63UXoKSW6JHR0BmHwJS3fEtE9rMMeVeQljv Z8pjJ/CR5ecsw== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1onguM-00026t-U4; Wed, 26 Oct 2022 15:57:27 +0200 From: Johan Hovold To: Mark Rutland , Lorenzo Pieralisi Cc: Ulf Hansson , Dmitry Baryshkov , Sudeep Holla , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2] firmware/psci: demote suspend-mode warning to info level Date: Wed, 26 Oct 2022 15:54:45 +0200 Message-Id: <20221026135445.8004-1-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On some Qualcomm platforms, like SC8280XP, the attempt to set PC mode during boot fails with PSCI_RET_DENIED and since commit 998fcd001feb ("firmware/psci: Print a warning if PSCI doesn't accept PC mode") this is now logged at warning level: psci: failed to set PC mode: -3 As there is nothing users can do about the firmware behaving this way, demote the warning to info level and clearly mark it as a firmware bug: psci: [Firmware Bug]: failed to set PC mode: -3 Signed-off-by: Johan Hovold --- drivers/firmware/psci/psci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c index e7bcfca4159f..f8fa32f0a130 100644 --- a/drivers/firmware/psci/psci.c +++ b/drivers/firmware/psci/psci.c @@ -165,7 +165,8 @@ int psci_set_osi_mode(bool enable) err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); if (err < 0) - pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); + pr_info(FW_BUG "failed to set %s mode: %d\n", + enable ? "OSI" : "PC", err); return psci_to_linux_errno(err); } -- 2.37.3