From: Stephen Boyd <sboyd@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
linux-kernel@vger.kernel.org
Cc: Amarula patchwork <linux-amarula@amarulasolutions.com>,
michael@amarulasolutions.com,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Turquette <mturquette@baylibre.com>,
Tero Kristo <kristo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tony Lindgren <tony@atomide.com>,
linux-clk@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] clk: ti: mux: don't free `parent_names' on kzalloc() failure
Date: Thu, 27 Oct 2022 17:41:09 -0700 [thread overview]
Message-ID: <20221028004112.88078C433C1@smtp.kernel.org> (raw)
In-Reply-To: <20221017164646.4193618-1-dario.binacchi@amarulasolutions.com>
Quoting Dario Binacchi (2022-10-17 09:46:46)
> Although no operation is performed by kfree() on a NULL pointer, it's
> however suboptimal and semantically wrong doing it.
Passing NULL to kfree() is fine. This is trying to optimize an error
path as well. No thanks.
prev parent reply other threads:[~2022-10-28 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 16:46 Dario Binacchi
2022-10-28 0:41 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028004112.88078C433C1@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=gregkh@linuxfoundation.org \
--cc=kristo@kernel.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®