From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH v2 05/13] staging: r8188eu: make OnAction_p2p static void
Date: Sun, 30 Oct 2022 18:33:18 +0100 [thread overview]
Message-ID: <20221030173326.1588647-6-martin@kaiser.cx> (raw)
In-Reply-To: <20221030173326.1588647-1-martin@kaiser.cx>
OnAction_p2p is called only by OnAction, its return value is not checked.
We can make it a static void function.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 9 ++++-----
drivers/staging/r8188eu/include/rtw_mlme_ext.h | 3 ---
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 779c022b1c50..f1054192bfb1 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -3832,7 +3832,7 @@ static void on_action_public(struct adapter *padapter, struct recv_frame *precv_
}
}
-unsigned int OnAction_p2p(struct adapter *padapter, struct recv_frame *precv_frame)
+static void OnAction_p2p(struct adapter *padapter, struct recv_frame *precv_frame)
{
u8 *frame_body;
u8 category, OUI_Subtype;
@@ -3842,16 +3842,16 @@ unsigned int OnAction_p2p(struct adapter *padapter, struct recv_frame *precv_fra
/* check RA matches or not */
if (memcmp(myid(&padapter->eeprompriv), GetAddr1Ptr(pframe), ETH_ALEN))/* for if1, sta/ap mode */
- return _SUCCESS;
+ return;
frame_body = (unsigned char *)(pframe + sizeof(struct ieee80211_hdr_3addr));
category = frame_body[0];
if (category != RTW_WLAN_CATEGORY_P2P)
- return _SUCCESS;
+ return;
if (be32_to_cpu(*((__be32 *)(frame_body + 1))) != P2POUI)
- return _SUCCESS;
+ return;
len -= sizeof(struct ieee80211_hdr_3addr);
OUI_Subtype = frame_body[5];
@@ -3869,7 +3869,6 @@ unsigned int OnAction_p2p(struct adapter *padapter, struct recv_frame *precv_fra
default:
break;
}
- return _SUCCESS;
}
static void OnAction(struct adapter *padapter, struct recv_frame *precv_frame)
diff --git a/drivers/staging/r8188eu/include/rtw_mlme_ext.h b/drivers/staging/r8188eu/include/rtw_mlme_ext.h
index 4ccdce1ad9be..ce5b57e23e53 100644
--- a/drivers/staging/r8188eu/include/rtw_mlme_ext.h
+++ b/drivers/staging/r8188eu/include/rtw_mlme_ext.h
@@ -536,9 +536,6 @@ void start_clnt_auth(struct adapter *padapter);
void start_clnt_join(struct adapter *padapter);
void start_create_ibss(struct adapter *padapter);
-unsigned int OnAction_p2p(struct adapter *padapter,
- struct recv_frame *precv_frame);
-
void mlmeext_joinbss_event_callback(struct adapter *padapter, int join_res);
void mlmeext_sta_del_event_callback(struct adapter *padapter);
void mlmeext_sta_add_event_callback(struct adapter *padapter,
--
2.30.2
next prev parent reply other threads:[~2022-10-30 17:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 17:33 [PATCH v2 00/13] staging: r8188eu: clean up action frame handlers Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 01/13] staging: r8188eu: replace a GetAddr1Ptr call Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 02/13] staging: r8188eu: remove duplicate category check Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 03/13] staging: r8188eu: make on_action_public static void Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 04/13] staging: r8188eu: make OnAction_back " Martin Kaiser
2022-10-30 17:33 ` Martin Kaiser [this message]
2022-10-30 17:33 ` [PATCH v2 06/13] staging: r8188eu: remove category check in OnAction_p2p Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 07/13] staging: r8188eu: replace switch-case with if Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 08/13] staging: r8188eu: replace GetAddr1Ptr call in OnAction_p2p Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 09/13] staging: r8188eu: clean up on_action_public Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 10/13] staging: r8188eu: remove return value from on_action_public_vendor Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 11/13] staging: r8188eu: remove return value from on_action_public_default Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 12/13] staging: r8188eu: rtw_action_public_decache's token is a u8 Martin Kaiser
2022-10-30 17:33 ` [PATCH v2 13/13] staging: r8188eu: check destination address in OnAction Martin Kaiser
2022-10-30 18:17 ` [PATCH v2 00/13] staging: r8188eu: clean up action frame handlers Philipp Hortmann
2022-10-30 18:48 ` Martin Kaiser
2022-10-30 19:15 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030173326.1588647-6-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®