From: Han Xu <han.xu@nxp.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Haibo Chen <haibo.chen@nxp.com>,
Yogesh Gaur <yogeshgaur.83@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: nxp-fspi: make const array ls1028a_soc_attr static
Date: Wed, 2 Nov 2022 11:19:17 -0500 [thread overview]
Message-ID: <20221102161857.7t7dqipgfsh2cgtf@umbrella> (raw)
In-Reply-To: <20221102152904.143423-1-colin.i.king@gmail.com>
On 22/11/02 03:29PM, Colin Ian King wrote:
> Don't populate the const array ls1028a_soc_attr on the stack, instead
> make it static. Also makes the object code smaller.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/spi/spi-nxp-fspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
> index d6a65a989ef8..1c1991a26c15 100644
> --- a/drivers/spi/spi-nxp-fspi.c
> +++ b/drivers/spi/spi-nxp-fspi.c
> @@ -924,7 +924,7 @@ static int nxp_fspi_adjust_op_size(struct spi_mem *mem, struct spi_mem_op *op)
>
> static void erratum_err050568(struct nxp_fspi *f)
> {
> - const struct soc_device_attribute ls1028a_soc_attr[] = {
> + static const struct soc_device_attribute ls1028a_soc_attr[] = {
> { .family = "QorIQ LS1028A" },
> { /* sentinel */ }
> };
Acked-by: Han Xu <han.xu@nxp.com>
> --
> 2.37.3
>
next prev parent reply other threads:[~2022-11-02 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 15:29 Colin Ian King
2022-11-02 16:19 ` Han Xu [this message]
2022-11-02 17:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102161857.7t7dqipgfsh2cgtf@umbrella \
--to=han.xu@nxp.com \
--cc=broonie@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=yogeshgaur.83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®