From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D36BC433FE for ; Fri, 4 Nov 2022 00:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230261AbiKDA0V (ORCPT ); Thu, 3 Nov 2022 20:26:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbiKDA0S (ORCPT ); Thu, 3 Nov 2022 20:26:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0625DF34 for ; Thu, 3 Nov 2022 17:26:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A6686206A for ; Fri, 4 Nov 2022 00:26:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AC03C433C1; Fri, 4 Nov 2022 00:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667521576; bh=Qeet/mfQtqAULjoGopJ7IxIdroJcaJ0GW6y0KQrk2AY=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=TBEg26IJMzoSY8V5enBN/5CFbpT8LOceojAkabxZGEzhKq99VbPOnIWk6iGlhn2ti ykf0y05A+ddtVfWFT+Z9rI6dI1bS/8xk+JYTZUz+33nSzzcHL0LdmqJ6fFxDA6bFu+ pxknsiA9eb5bk/0rKrGyYMp8+D5P6NeKU9j0LFuaWFVFQNBlcJ2wtCh4gAPKXsWDcz ollREZKwLKWtM9d2OCMhcqmdN4MHIUSg/gGMqBzMyK4/s3ME17FXRUcY26TiEpaMZ2 Wuy+WczzzOT9JcRsHRpByn5hoRXTGA6RgdQi+VH2r+8bVHPyEarHupt4nSv2ArwDRW GfGDpHgZvRqVA== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 2E3B85C097E; Thu, 3 Nov 2022 17:26:16 -0700 (PDT) Date: Thu, 3 Nov 2022 17:26:16 -0700 From: "Paul E. McKenney" To: Waiman Long Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, john.stultz@linaro.org, sboyd@kernel.org, corbet@lwn.net, Mark.Rutland@arm.com, maz@kernel.org, kernel-team@meta.com, neeraju@codeaurora.org, ak@linux.intel.com, feng.tang@intel.com, zhengjun.xing@intel.com, John Stultz Subject: Re: [PATCH clocksource 2/2] clocksource: Exponential backoff for load-induced bogus watchdog reads Message-ID: <20221104002616.GH5600@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20221102184001.GA1306489@paulmck-ThinkPad-P17-Gen-1> <20221102184009.1306751-2-paulmck@kernel.org> <1fdbdf78-cdca-975f-7f57-e391263d0aec@redhat.com> <20221103204910.GF5600@paulmck-ThinkPad-P17-Gen-1> <61470eb8-fc3c-7f95-881e-03da1805b5ac@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61470eb8-fc3c-7f95-881e-03da1805b5ac@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2022 at 08:20:27PM -0400, Waiman Long wrote: > On 11/3/22 16:49, Paul E. McKenney wrote: > > commit da44b8af99222ff8761a98ca8c00837a7d607d28 > > Author: Paul E. McKenney > > Date: Fri Oct 28 10:38:58 2022 -0700 > > > > clocksource: Exponential backoff for load-induced bogus watchdog reads > > The clocksource watchdog will reject measurements that are excessively > > delayed, that is, by more than 1.5 seconds beyond the intended 0.5-second > > watchdog interval. On an extremely busy system, this can result in a > > console message being printed every two seconds. This is excessively > > noisy for a non-error condition. > > Therefore, apply exponential backoff to these messages. This exponential > > backoff is capped at 1024 times the watchdog interval, which comes to > > not quite one message per ten minutes. > > Please note that the bogus watchdog reads that occur when the watchdog > > interval is less than 0.125 seconds are still printed unconditionally > > because these likely correspond to a serious error condition in the > > timer code or hardware. > > [ paulmck: Apply Feng Tang feedback. ] > > [ paulmck: Apply Waiman Long feedback. ] > > Reported-by: Waiman Long > > Reported-by: Feng Tang > > Signed-off-by: Paul E. McKenney > > Cc: John Stultz > > Cc: Thomas Gleixner > > Cc: Stephen Boyd > > Cc: Feng Tang > > Cc: Waiman Long > > > > diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h > > index 1d42d4b173271..23b73f2293d6d 100644 > > --- a/include/linux/clocksource.h > > +++ b/include/linux/clocksource.h > > @@ -125,6 +125,9 @@ struct clocksource { > > struct list_head wd_list; > > u64 cs_last; > > u64 wd_last; > > + u64 wd_last_bogus; > > + int wd_bogus_shift; > > + unsigned long wd_bogus_count; > > #endif > > struct module *owner; > > }; > > diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c > > index 3f5317faf891f..1eefb56505350 100644 > > --- a/kernel/time/clocksource.c > > +++ b/kernel/time/clocksource.c > > @@ -442,14 +442,33 @@ static void clocksource_watchdog(struct timer_list *unused) > > /* Check for bogus measurements. */ > > wdi = jiffies_to_nsecs(WATCHDOG_INTERVAL); > > - if (wd_nsec < (wdi >> 2)) { > > - /* This usually indicates broken timer code or hardware. */ > > - pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advanced only %lld ns during %d-jiffy time interval, skipping watchdog check.\n", smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL); > > + if (wd_nsec > (wdi << 2) || cs_nsec > (wdi << 2)) { > > + bool needwarn = false; > > + u64 wd_lb; > > + > > + cs->wd_bogus_count++; > > + if (!cs->wd_bogus_shift) { > > + needwarn = true; > > + } else { > > + delta = clocksource_delta(wdnow, cs->wd_last_bogus, watchdog->mask); > > + wd_lb = clocksource_cyc2ns(delta, watchdog->mult, watchdog->shift); > > + if ((1 << cs->wd_bogus_shift) * wdi <= wd_lb) > > + needwarn = true; > > + } > > + if (needwarn) { > > + /* This can happen on busy systems, which can delay the watchdog. */ > > + pr_warn("timekeeping watchdog on CPU%d: Watchdog clocksource '%s' advanced an excessive %lld ns during %d-jiffy time interval (%lu additional), probable CPU overutilization, skipping watchdog check.\n", smp_processor_id(), watchdog->name, wd_nsec, WATCHDOG_INTERVAL, cs->wd_bogus_count); > > Just one question, does "%lu additional" means the number of bogus count > that doesn't meet the needwarn requirement and hence skipped. If so, I think > you have to use "cs->wd_bogus_cnt - 1". Other than that, the change looks > good to me. It means the number since the last report, or, for the first report, the number since boot. Does that work for you? Thanx, Paul