From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
x86@kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH v2 2/5] x86: remove unneeded 64-bit dependency in arch_enter_from_user_mode()
Date: Fri, 4 Nov 2022 08:26:58 +0100 [thread overview]
Message-ID: <20221104072701.20283-3-jgross@suse.com> (raw)
In-Reply-To: <20221104072701.20283-1-jgross@suse.com>
The check for 64-bit mode when testing X86_FEATURE_XENPV isn't needed,
as Xen PV guests are no longer supported in 32-bit mode.
While at it switch from boot_cpu_has() to cpu_feature_enabled().
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/include/asm/entry-common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/entry-common.h b/arch/x86/include/asm/entry-common.h
index 674ed46d3ced..117903881fe4 100644
--- a/arch/x86/include/asm/entry-common.h
+++ b/arch/x86/include/asm/entry-common.h
@@ -24,8 +24,8 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs)
/*
* For !SMAP hardware we patch out CLAC on entry.
*/
- if (boot_cpu_has(X86_FEATURE_SMAP) ||
- (IS_ENABLED(CONFIG_64BIT) && boot_cpu_has(X86_FEATURE_XENPV)))
+ if (cpu_feature_enabled(X86_FEATURE_SMAP) ||
+ cpu_feature_enabled(X86_FEATURE_XENPV))
mask |= X86_EFLAGS_AC;
WARN_ON_ONCE(flags & mask);
--
2.35.3
next prev parent reply other threads:[~2022-11-04 7:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 7:26 [PATCH v2 0/5] x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use Juergen Gross
2022-11-04 7:26 ` [PATCH v2 1/5] x86: add X86_FEATURE_XENPV to disabled-features.h Juergen Gross
2022-11-04 14:56 ` Dave Hansen
2022-11-22 18:04 ` [tip: x86/cpu] x86/cpufeatures: Add " tip-bot2 for Juergen Gross
2022-11-04 7:26 ` Juergen Gross [this message]
2022-11-04 14:58 ` [PATCH v2 2/5] x86: remove unneeded 64-bit dependency in arch_enter_from_user_mode() Dave Hansen
2022-11-22 18:04 ` [tip: x86/cpu] x86/cpu: Remove " tip-bot2 for Juergen Gross
2022-11-04 7:26 ` [PATCH v2 3/5] x86: drop 32-bit Xen PV guest code in update_task_stack() Juergen Gross
2022-11-04 15:04 ` Dave Hansen
2022-11-22 18:04 ` [tip: x86/cpu] x86/cpu: Drop " tip-bot2 for Juergen Gross
2022-11-04 7:27 ` [PATCH v2 4/5] x86: remove X86_FEATURE_XENPV usage in setup_cpu_entry_area() Juergen Gross
2022-11-04 15:04 ` Dave Hansen
2022-11-22 18:04 ` [tip: x86/cpu] x86/cpu: Remove " tip-bot2 for Juergen Gross
2022-11-04 7:27 ` [PATCH v2 5/5] x86: switch to cpu_feature_enabled() for X86_FEATURE_XENPV Juergen Gross
2022-11-04 17:32 ` Dave Hansen
2022-11-22 18:04 ` [tip: x86/cpu] x86/cpu: Switch " tip-bot2 for Juergen Gross
2022-11-22 12:47 ` [PATCH v2 0/5] x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104072701.20283-3-jgross@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome