From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 5/9] staging: r8188eu: remove state checks in rtw_led_control
Date: Sun, 6 Nov 2022 13:48:57 +0100 [thread overview]
Message-ID: <20221106124901.720785-6-martin@kaiser.cx> (raw)
In-Reply-To: <20221106124901.720785-1-martin@kaiser.cx>
There's no need to check for bSurpriseRemoved or bDriverStopped in the
rtw_led_control function. This function schedules a delayed worker which
calls SwLedOn or SwLedOff (or the function calls SwLedOff directly).
SwLedOn and SwLedOff check bDriverStopped themselves or they initiate a
USB control transfer via usb_write, where bSurpriseRemoved is checked.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_led.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c
index ce8de2eb7845..48725ce9d369 100644
--- a/drivers/staging/r8188eu/core/rtw_led.c
+++ b/drivers/staging/r8188eu/core/rtw_led.c
@@ -140,8 +140,7 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
struct registry_priv *registry_par;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
- if ((padapter->bSurpriseRemoved) || (padapter->bDriverStopped) ||
- (!padapter->hw_init_completed))
+ if (!padapter->hw_init_completed)
return;
if (!pLed->bRegUseLed)
--
2.30.2
next prev parent reply other threads:[~2022-11-06 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 12:48 [PATCH 0/9] staging: r8188eu: another round of cleanups Martin Kaiser
2022-11-06 12:48 ` [PATCH 1/9] staging: r8188eu: don't store addba request Martin Kaiser
2022-11-06 12:48 ` [PATCH 2/9] staging: r8188eu: remove some obsolete comments Martin Kaiser
2022-11-06 12:48 ` [PATCH 3/9] staging: r8188eu: reorder assignments, clarify the header format Martin Kaiser
2022-11-06 12:48 ` [PATCH 4/9] staging: r8188eu: reformat a function header Martin Kaiser
2022-11-06 12:48 ` Martin Kaiser [this message]
2022-11-06 12:48 ` [PATCH 6/9] staging: r8188eu: clean up rtw_hal_init Martin Kaiser
2022-11-06 12:48 ` [PATCH 7/9] staging: r8188eu: remove get_fwstate Martin Kaiser
2022-11-06 12:49 ` [PATCH 8/9] staging: r8188eu: merge two rtw_free_network_nolock functions Martin Kaiser
2022-11-06 12:49 ` [PATCH 9/9] staging: r8188eu: remove checks in dump_mgntframe Martin Kaiser
2022-11-07 6:22 ` [PATCH 0/9] staging: r8188eu: another round of cleanups Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221106124901.720785-6-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®