From: Guenter Roeck <linux@roeck-us.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Julia Lawall <Julia.Lawall@inria.fr>
Subject: Re: [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*()
Date: Sun, 6 Nov 2022 14:52:11 -0800 [thread overview]
Message-ID: <20221106225211.GB805009@roeck-us.net> (raw)
In-Reply-To: <CAHk-=whO5PXEzWwf=4=fvdqim6cGTczVoN4KJ5H+dabHo-OTHw@mail.gmail.com>
On Sun, Nov 06, 2022 at 02:40:14PM -0800, Linus Torvalds wrote:
> On Sun, Nov 6, 2022 at 1:52 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > I can update the change log to include:
>
> Yup, full running instructions for coccinelle patches is probably a good idea.
>
> I've done them semi-occasionally, but it's rare enough that I always
> have to look it up anyway, and I suspect many others have never done
> it, so having it in the commit message is probably a good idea.
>
> > when != ptr->timer.function = E;
>
> I do think that you should just remove that E expression and the
> "function = E" part.
>
Agreed. Removing this line does not make a difference. It looks like the
"when strict" takes care of the condition.
Guenter
next prev parent reply other threads:[~2022-11-06 22:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-06 5:45 [PATCH v5a 0/5] timers: Use timer_shutdown*() before freeing timers Steven Rostedt
2022-11-06 5:45 ` [PATCH v5a 2/5] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function Steven Rostedt
2022-11-06 11:09 ` Marc Zyngier
2022-11-07 11:03 ` Mark Rutland
2022-11-06 5:45 ` [PATCH v5a 3/5] clocksource/drivers/sp804: " Steven Rostedt
2022-11-06 5:45 ` [PATCH v5a 4/5] timers: Add timer_shutdown_sync() and timer_shutdown() to be called before freeing timers Steven Rostedt
2022-11-06 5:45 ` [PATCH v5a 5/5] treewide: Convert del_timer*() to timer_shutdown*() Steven Rostedt
2022-11-06 20:51 ` Linus Torvalds
2022-11-06 21:09 ` Steven Rostedt
2022-11-06 21:15 ` Guenter Roeck
2022-11-06 21:18 ` Steven Rostedt
2022-11-06 21:39 ` Linus Torvalds
2022-11-06 21:52 ` Steven Rostedt
2022-11-06 22:40 ` Linus Torvalds
2022-11-06 22:52 ` Guenter Roeck [this message]
2022-11-06 22:52 ` Steven Rostedt
2022-11-06 23:05 ` Linus Torvalds
2022-11-06 23:09 ` Julia Lawall
2022-11-06 23:08 ` Julia Lawall
2022-11-06 17:08 ` [PATCH v5a 0/5] timers: Use timer_shutdown*() before freeing timers Guenter Roeck
2022-11-06 18:25 ` Steven Rostedt
[not found] ` <20221106054648.367234222@goodmis.org>
2022-11-07 5:47 ` [PATCH v5a 1/5] ARM: spear: Do not use timer namespace for timer_shutdown() function Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221106225211.GB805009@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Julia.Lawall@inria.fr \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®