From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Alexander Lobakin <alexandr.lobakin@intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Tony Luck <tony.luck@intel.com>,
Kees Cook <keescook@chromium.org>,
Masahiro Yamada <masahiroy@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] x86/boot: fix relying on link order
Date: Mon, 7 Nov 2022 13:55:28 +0100 [thread overview]
Message-ID: <20221107125528.543764-1-alexandr.lobakin@intel.com> (raw)
In-Reply-To: <20221101161529.1634188-1-alexandr.lobakin@intel.com>
From: Alexander Lobakin <alexandr.lobakin@intel.com>
Date: Tue, 1 Nov 2022 17:15:27 +0100
> The series contains stuff I caught last week while working on some
> x86 code. It can be considered a material for fixes or for next,
> I'm okay with either, although leaning more towards fixes :P
>
> Notes on patches:
> * 0001: I didn't put any "Fixes:" tag since it's not linear. The
> lines changed with this patch came from the initial x86
> KASLR series, but that unconditional jump to the kernel
> beginning already was there. It goes at least from the set
> that brought relocatable kernel support to x86, but this
> is quite prehistoric already and might not look really
> relatable. So up to you whether it needs any.
> * 0002: doesn't fix anything, except that having any files listed
> in that whitelist already is an architecture bug :D And
> it wouldn't be convenient to decouple it from #0001, but
> up to you as well.
>
> From v1[0]:
> * collect the Tested-by tags (Jiri);
> * don't add pathetic returns after noreturn error() (Jiri);
> * debug-print the entry point offset via debug_putaddr() before
> booting (Jiri);
> * always have an empty line before return statements (Jiri).
>
> [0] https://lore.kernel.org/all/20221031151047.167288-1-alexandr.lobakin@intel.com
>
> Alexander Lobakin (2):
> x86/boot: robustify calling startup_{32,64}() from the decompressor
> code
> scripts/head-object-list: remove x86 from the list
>
> arch/x86/boot/compressed/head_32.S | 2 +-
> arch/x86/boot/compressed/head_64.S | 2 +-
> arch/x86/boot/compressed/misc.c | 16 ++++++++++------
> scripts/head-object-list.txt | 6 ------
> 4 files changed, 12 insertions(+), 14 deletions(-)
Ping?
Also, I managed to remove .head.text at all from x86. Would it be
better to respin this series with the third patch or send a
follow-up later?
>
> --
> 2.38.1
Thanks,
Olek
next prev parent reply other threads:[~2022-11-07 12:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 16:15 Alexander Lobakin
2022-11-01 16:15 ` [PATCH v2 1/2] x86/boot: robustify calling startup_{32,64}() from the decompressor code Alexander Lobakin
2022-11-02 6:14 ` Jiri Slaby
2022-11-01 16:15 ` [PATCH v2 2/2] scripts/head-object-list: remove x86 from the list Alexander Lobakin
2022-11-07 12:55 ` Alexander Lobakin [this message]
2022-11-08 23:09 ` [PATCH v2 0/2] x86/boot: fix relying on link order Dave Hansen
2022-11-21 12:09 ` Alexander Lobakin
2022-11-21 13:14 ` Borislav Petkov
2022-11-21 16:00 ` Alexander Lobakin
2022-12-07 15:08 ` Alexander Lobakin
2022-12-07 15:24 ` Borislav Petkov
2022-12-07 15:30 ` Alexander Lobakin
2022-12-07 15:52 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221107125528.543764-1-alexandr.lobakin@intel.com \
--to=alexandr.lobakin@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome