From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D90F1C4332F for ; Wed, 9 Nov 2022 02:09:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229850AbiKICJZ (ORCPT ); Tue, 8 Nov 2022 21:09:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbiKICJW (ORCPT ); Tue, 8 Nov 2022 21:09:22 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 149F55D698 for ; Tue, 8 Nov 2022 18:09:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BC269B81CF2 for ; Wed, 9 Nov 2022 02:09:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 633B8C433C1; Wed, 9 Nov 2022 02:09:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667959759; bh=GX1WjxW5uIqLEw8Wf86wBcBw2yon78ZixjUQkvdfwEM=; h=From:To:Cc:Subject:Date:From; b=e0R6UZj9AmzXm6wp3136fx0o1LvJiv/VAof9ELNn8s6q2CbXVQStgxEMGcgNykFDz rszEN5NztQnopREbtuR1A17yGS4s3zVWn9zi9Z0qYKGbpsvoHUEFcyJGl01NXi55OF xkZVnE3bMo2mdmkvBvCz7hXCPPC8MOygywIkvzihalQzAq1jVzsVoMV5qG1mie1cE/ PNu9mkCtWzDke1b98p4ddWi1ZuuCXJGLlsOinA65momdq6iDJPAbTKxDiQVQ/BCKgK pCXwle+mh97lr0xssPc3+vtM2SxDoq1bHeA/zWAGr7jDXiXpZW6JRCvtUZmGJEVPYZ lonJyYW+8db6A== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: allow to read node block after shutdown Date: Tue, 8 Nov 2022 18:09:17 -0800 Message-Id: <20221109020917.4121067-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If block address is still alive, we should give a valid node block even after shutdown. Otherwise, we can see zero data when reading out a file. Fixes: 83a3bfdb5a8 ("f2fs: indicate shutdown f2fs to allow unmount successfully") Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 983572f23896..b9ee5a1176a0 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1360,8 +1360,7 @@ static int read_node_page(struct page *page, blk_opf_t op_flags) return err; /* NEW_ADDR can be seen, after cp_error drops some dirty node pages */ - if (unlikely(ni.blk_addr == NULL_ADDR || ni.blk_addr == NEW_ADDR) || - is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN)) { + if (unlikely(ni.blk_addr == NULL_ADDR || ni.blk_addr == NEW_ADDR)) { ClearPageUptodate(page); return -ENOENT; } -- 2.38.1.431.g37b22c650d-goog