From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A8DC4332F for ; Wed, 9 Nov 2022 18:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230224AbiKISDG (ORCPT ); Wed, 9 Nov 2022 13:03:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231847AbiKISCW (ORCPT ); Wed, 9 Nov 2022 13:02:22 -0500 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 255831F9D7; Wed, 9 Nov 2022 10:01:08 -0800 (PST) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id 36AEB5FD1F; Wed, 9 Nov 2022 21:01:05 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1668016865; bh=8Lp5KldxGfUo63YiVCKnD2SRpgAs+qCswo0OBYx+Ijw=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=fTVx61NeffKm7MK0Ck0jVVvlMjXhHFF3ZqLwu/aJAJpP4mTaaOWL+emVlimJT7sxO bpvc2Nxvm81xN/EqzBjKs45w5RrwJbfgWPP94kVBGiHGDeIMmNrIVt3IZASQOaHn1c ZeW8IMX0AwurZUmZ98v3pMNp+h2ElvOjRa1aupZCya773b5DGLlE7c7HndIOzbYz8A 96Qp1e1J7BB/6uYs4kUSpEETBTjRtfg/e61Ew6fxXv99EB2pufR7eBXXWKEDyUvmr7 grGbDGDnLIYfW+kIBf9tm/yHEP65+mKcH8eKnnthKR2HHB0V/mIKbNqVCxBeowuHIA IRTLdHezPJcTA== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Wed, 9 Nov 2022 21:01:04 +0300 (MSK) Date: Wed, 9 Nov 2022 21:01:04 +0300 From: Dmitry Rokosov To: Pavel Machek CC: "linux-kernel@vger.kernel.org" , "linux-leds@vger.kernel.org" , Arseniy Krasnov , kernel Subject: Re: [RFC PATCH v1 1/1] leds: support to use own workqueue for each LED Message-ID: <20221109180104.x434mr72c2sgi5s3@CAB-WSD-L081021> References: <9a0a70a8-0886-1115-6151-72d2cba842cf@sberdevices.ru> <33d05330-7c52-e873-bf32-209d40c77632@sberdevices.ru> <20221030122029.GA8017@duo.ucw.cz> <20221030201527.GA23195@duo.ucw.cz> <03bc76b5-4e2e-5d4d-96b5-53a1f95ffd0c@sberdevices.ru> <20221031144704.ir5iks6ohh3negsx@CAB-WSD-L081021> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20221031144704.ir5iks6ohh3negsx@CAB-WSD-L081021> User-Agent: NeoMutt/20220415 X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH01.sberdevices.ru (172.16.1.4) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2022/11/09 03:44:00 #20576823 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Pavel, Do you have any feedback/thoughts about this one? The problem looks very bad, Load Average value should not grow up due to any userspace triggered led animation. I suppose we stronlgy need to fixup this behavior for sure. Appreciate any help! On Mon, Oct 31, 2022 at 05:47:04PM +0300, Dmitry Rokosov wrote: > Hello Pavel and Arseniy, > > Please find my thoughts below. > > On Mon, Oct 31, 2022 at 10:01:28AM +0300, Arseniy Krasnov wrote: > > On 30.10.2022 23:15, Pavel Machek wrote: > > > Hi! > > > > > >>>> This allows to set own workqueue for each LED. This may be useful, because > > >>>> default 'system_wq' does not guarantee execution order of each work_struct, > > >>>> thus for several brightness update requests (for multiple leds), real > > >>>> brightness switch could be in random order. > > >>> > > >>> So.. what? > > >>> > > >>> Even if execution order is switched, human eye will not be able to > > >>> tell the difference. > > >> Hello, > > >> > > >> Problem arises on one of our boards where we have 14 triples of leds(each > > >> triple contains R G B). Test case is to play complex animation on all leds: > > >> smooth switch from on RGB state to another. Sometimes there are glitches in > > >> this process - divergence from expectable RGB state. We fixed this by using > > >> ordered workqueue. > > > > > > Are there other solutions possible? Like batch and always apply _all_ > > > the updates you have queued from your the worker code? > > > > IIUC You, it is possible to do this if brightness update requests are performed using > > write to "brightness" file in /sys/class/led/. But if pattern trigger mode is used(in my > > case) - I can't synchronize these requests as they are created internally in kernel on > > timer tick. > > Even more, system_wq is used when you push brightness changing requests > to sysfs node, and it could be re-ordered as well. In other words, from > queue perspective sysfs iface and trigger iface have the same behavior. > > Also we can be faced with another big problem here: let's imagine you have > I2C based LED controller driver. Usually, in such drivers you're stuck > to the one driver owned mutex, which protects I2C transactions from each > other. > > When you change brightness very often (let's say a hundred thousand times > per minute) you schedule many workers to system_wq. Due to system_wq is > multicore and unordered it creates many kworkers. Each kworker stucks on > the driver mutex and goes to TASK_UNINTERRUPTIBLE state. It affects Load > Average value so much. On the our device LA maximum could reach 30-35 > units due to such idle kworkers. > > I'm not sure custom workqueue initialization from specific HW driver is > a good solution... But it's much better than nothing. > > Pavel, please share your thoughts about above problems? Maybe you have > more advanced and scalable solution idea, I would appreciate if you > could share it with us. -- Thank you, Dmitry