From: "Paul E. McKenney" <paulmck@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Guilherme G. Piccoli" <gpiccoli@igalia.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"rcu@vger.kernel.org" <rcu@vger.kernel.org>,
"kernel-dev@igalia.com" <kernel-dev@igalia.com>,
"Guilherme G. Piccoli" <kernel@gpiccoli.net>
Subject: Re: RCU stall on 6.1-rc4 (and some previous releases) related to ftrace
Date: Thu, 10 Nov 2022 19:37:12 -0800 [thread overview]
Message-ID: <20221111033712.GO725751@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <20221110191651.3a177417@rorschach.local.home>
On Thu, Nov 10, 2022 at 07:16:51PM -0500, Steven Rostedt wrote:
> On Thu, 10 Nov 2022 18:25:41 -0300
> "Guilherme G. Piccoli" <gpiccoli@igalia.com> wrote:
>
> > @@ -4184,6 +4184,7 @@ match_records(struct ftrace_hash *hash, char *func, int len, char *mod)
> > if (rec->flags & FTRACE_FL_DISABLED)
> > continue;
> >
> > + cond_resched();
> > if (ftrace_match_record(rec, &func_g, mod_match, exclude_mod)) {
> > ret = enter_record(hash, rec, clear_filter);
> > if (ret < 0) {
>
> This isn't where I would put it. I would add it after the if statement.
> That is, at the end of the loop.
I am good either way. Though one could argue for putting it at the
beginning of the loop in case every element takes that "continue" above...
Thanx, Paul
next prev parent reply other threads:[~2022-11-11 3:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 21:25 Guilherme G. Piccoli
2022-11-10 23:08 ` Paul E. McKenney
2022-11-11 0:16 ` Steven Rostedt
2022-11-11 3:37 ` Paul E. McKenney [this message]
2022-11-15 20:53 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111033712.GO725751@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®