From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BBDFC433FE for ; Fri, 11 Nov 2022 04:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232032AbiKKEZS (ORCPT ); Thu, 10 Nov 2022 23:25:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231559AbiKKEZI (ORCPT ); Thu, 10 Nov 2022 23:25:08 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 015FB6828E for ; Thu, 10 Nov 2022 20:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668140706; x=1699676706; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=rRCWr54MBfM38aSNFQijVwdAC/iSuunIyJ/8rXD9+Rw=; b=EQSYBhSGESzefNchMxwiM4MNyUvQCUKDoEx7lksBkYolNHpwyJhhQDtE 0KS75tExJivFZI8fsbeSCJ4g8Zry1Cl1gg8S5EJ4oBx8Oz8hd+SC7LBDp KfXmJgYCk2Kdkom3DGYp6BNdvgbWmVVCCAOiCVfjgojAGL6inlRQXfawj TSBOEsBj00mt4PCKo/J7LPXExCvQMnoJ5BEJjybsJb61bgEXvzW/KnEze Apcfoye5n79zR7/B/ZolWkTrD4OVrvPb/M6SHKkLObiRXza/svtQe1+aw uxMaNQF16GyFP2hdISNy7/AeShlQ9+XPo6VfGtVupxaCtZoBbQZyN2Bc2 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="397816275" X-IronPort-AV: E=Sophos;i="5.96,155,1665471600"; d="scan'208";a="397816275" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 20:25:06 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="588440660" X-IronPort-AV: E=Sophos;i="5.96,155,1665471600"; d="scan'208";a="588440660" Received: from bard-ubuntu.sh.intel.com ([10.239.185.57]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 20:25:04 -0800 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com Subject: [PATCH 1/8] soundwire: intel_init: remove useless interrupt enablement in interrupt thread Date: Fri, 11 Nov 2022 12:26:46 +0800 Message-Id: <20221111042653.45520-2-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221111042653.45520-1-yung-chuan.liao@linux.intel.com> References: <20221111042653.45520-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pierre-Louis Bossart When the code reaches the SoundWire interrupt thread handling, the interrupt was enabled already, and there is no code that disables it -> this is a no-op sequence. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Péter Ujfalusi Reviewed-by: Ranjani Sridharan Signed-off-by: Bard Liao --- drivers/soundwire/intel_init.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c index d091513919df..8bd95c9cbcaf 100644 --- a/drivers/soundwire/intel_init.c +++ b/drivers/soundwire/intel_init.c @@ -157,7 +157,6 @@ irqreturn_t sdw_intel_thread(int irq, void *dev_id) list_for_each_entry(link, &ctx->link_list, list) sdw_cdns_irq(irq, link->cdns); - sdw_intel_enable_irq(ctx->mmio_base, true); return IRQ_HANDLED; } EXPORT_SYMBOL_NS(sdw_intel_thread, SOUNDWIRE_INTEL_INIT); -- 2.25.1