From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01778C433FE for ; Fri, 11 Nov 2022 12:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233723AbiKKMtA (ORCPT ); Fri, 11 Nov 2022 07:49:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231564AbiKKMs5 (ORCPT ); Fri, 11 Nov 2022 07:48:57 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60FCA42F68; Fri, 11 Nov 2022 04:48:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DBB66B825FE; Fri, 11 Nov 2022 12:48:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32EC6C433D6; Fri, 11 Nov 2022 12:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668170933; bh=mitaukNCb/hYAbTGvUtPs3BXT+tqSAvOYU4AGeN6OCM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IQPlqYJaTpOFi44ChAALquCTgyBXRwo6csMhPvf78cp7LsuwRqhhQGYJMfa0WDLSO 1vNcSjSBFeR3q6qfXxrbpkwP6YfRvTAyJji+b2lbwKU5V+qvI14shZql6XDpvgDvWS g+a8yajtrFB7iXMRyERYAP3MzuAAd+aMAm2mAR+WcfV0kw0yh5F3YGBblMlnZZXx8+ oh8GyQlbyxlEZ8g9c6O3w67Y558n4JX0FSyaYDc32NfEG0UK+CM5hr3vB6y7sdiUPC 6p46hjqM7ouSdjWDY4KJxkI7003iDnOZhh2gS3GJqSDjWLvpXlr/Xuh5VOtAsXjNzo tGO/TL+CQTAQg== Date: Fri, 11 Nov 2022 21:48:49 +0900 From: Masami Hiramatsu (Google) To: Aashish Sharma Cc: Steven Rostedt , "Martin K. Petersen" , Arun Easi , linux-kernel@vger.kernel.org, Linux Trace Kernel Subject: Re: [PATCH] tracing: Fix warning on variable 'struct trace_array' Message-Id: <20221111214849.895359f49037ec6cf21292a3@kernel.org> In-Reply-To: <20221107160556.2139463-1-shraash@google.com> References: <20221107160556.2139463-1-shraash@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Nov 2022 21:35:56 +0530 Aashish Sharma wrote: > Move the declaration of 'struct trace_array' out of #ifdef > CONFIG_TRACING block, to fix the following warning when CONFIG_TRACING > is not set: > > >> include/linux/trace.h:63:45: warning: 'struct trace_array' declared > inside parameter list will not be visible outside of this definition or > declaration > This looks good to me. Acked-by: Masami Hiramatsu (Google) Thank you! > Fixes: 1a77dd1c2bb5 ("scsi: tracing: Fix compile error in trace_array calls when TRACING is disabled") > Cc: Arun Easi > Signed-off-by: Aashish Sharma > --- > include/linux/trace.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/trace.h b/include/linux/trace.h > index b5e16e438448..80ffda871749 100644 > --- a/include/linux/trace.h > +++ b/include/linux/trace.h > @@ -26,13 +26,13 @@ struct trace_export { > int flags; > }; > > +struct trace_array; > + > #ifdef CONFIG_TRACING > > int register_ftrace_export(struct trace_export *export); > int unregister_ftrace_export(struct trace_export *export); > > -struct trace_array; > - > void trace_printk_init_buffers(void); > __printf(3, 4) > int trace_array_printk(struct trace_array *tr, unsigned long ip, > -- > 2.38.1.431.g37b22c650d-goog > -- Masami Hiramatsu (Google)