From: Khazhismel Kumykov <khazhy@chromium.org>
To: Paolo Valente <paolo.valente@linaro.org>, Jens Axboe <axboe@kernel.dk>
Cc: Arianna Avanzini <avanzini.arianna@gmail.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Khazhismel Kumykov <khazhy@google.com>
Subject: [PATCH] bfq: use configured slice_idle in bfq_bfqq_is_slow
Date: Fri, 11 Nov 2022 15:41:48 -0800 [thread overview]
Message-ID: <20221111234148.2608273-1-khazhy@google.com> (raw)
Missing a bfqd->, so we'd only ever use the default value here.
Fixes: ab0e43e9cea0 ("block, bfq: modify the peak-rate estimator")
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
---
block/bfq-iosched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
index 267baf84870f..827b878a0266 100644
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -4160,7 +4160,7 @@ static bool bfq_bfqq_is_slow(struct bfq_data *bfqd, struct bfq_queue *bfqq,
*/
*delta_ms = BFQ_MIN_TT / NSEC_PER_MSEC;
else /* charge at least one seek */
- *delta_ms = bfq_slice_idle / NSEC_PER_MSEC;
+ *delta_ms = bfqd->bfq_slice_idle / NSEC_PER_MSEC;
return slow;
}
--
2.38.1.431.g37b22c650d-goog
reply other threads:[~2022-11-11 23:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111234148.2608273-1-khazhy@google.com \
--to=khazhy@chromium.org \
--cc=avanzini.arianna@gmail.com \
--cc=axboe@kernel.dk \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®