Hi Asutosh,

I love your patch! Perhaps something to improve:

[auto build test WARNING on jejb-scsi/for-next]
[also build test WARNING on mkp-scsi/for-next linus/master v6.1-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Asutosh-Das/Add-Multi-Circular-Queue-Support/20221110-034847
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
patch link:    https://lore.kernel.org/r/c1883a3cc18cc0103a6664cde7afbeef6d5424d8.1668022680.git.quic_asutoshd%40quicinc.com
patch subject: [PATCH v4 14/16] ufs: mcq: Add completion support of a cqe
config: i386-randconfig-a002
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/3d6ff8e043038d2fbaae0f2ca6547ae3bf457283
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Asutosh-Das/Add-Multi-Circular-Queue-Support/20221110-034847
        git checkout 3d6ff8e043038d2fbaae0f2ca6547ae3bf457283
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/ufs/core/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/ufs/core/ufs-mcq.c:345:56: warning: shift count is negative [-Wshift-count-negative]
           dma_addr = le64_to_cpu(cqe->command_desc_base_addr) & CQE_UCD_BA;
                                                                 ^~~~~~~~~~
   drivers/ufs/core/ufs-mcq.c:31:20: note: expanded from macro 'CQE_UCD_BA'
   #define CQE_UCD_BA GENMASK(63, 7)
                      ^~~~~~~~~~~~~~
   include/linux/bits.h:38:31: note: expanded from macro 'GENMASK'
           (GENMASK_INPUT_CHECK(h, l) + __GENMASK(h, l))
                                        ^~~~~~~~~~~~~~~
   include/linux/bits.h:36:11: note: expanded from macro '__GENMASK'
            (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
                    ^  ~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning generated.


vim +345 drivers/ufs/core/ufs-mcq.c

   334	
   335	static int ufshcd_mcq_get_tag(struct ufs_hba *hba,
   336					     struct ufs_hw_queue *hwq,
   337					     struct cq_entry *cqe)
   338	{
   339		dma_addr_t dma_addr;
   340	
   341		/* sizeof(struct utp_transfer_cmd_desc) must be a multiple of 128 */
   342		BUILD_BUG_ON(sizeof(struct utp_transfer_cmd_desc) & GENMASK(6, 0));
   343	
   344		/* Bits 63:7 UCD base address, 6:5 are reserved, 4:0 is SQ ID */
 > 345		dma_addr = le64_to_cpu(cqe->command_desc_base_addr) & CQE_UCD_BA;
   346	
   347		return (dma_addr - hba->ucdl_dma_addr) /
   348			sizeof(struct utp_transfer_cmd_desc);
   349	}
   350	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp