Hi Colin, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Colin-Foster/cleanup-ocelot_stats-exposure/20221112-045112 patch link: https://lore.kernel.org/r/20221111204924.1442282-2-colin.foster%40in-advantage.com patch subject: [PATCH v1 net-next 1/2] net: mscc: ocelot: remove redundant stats_layout pointers config: x86_64-allyesconfig compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/08340d5695cf703f1714df628183554016c35107 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Colin-Foster/cleanup-ocelot_stats-exposure/20221112-045112 git checkout 08340d5695cf703f1714df628183554016c35107 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/ethernet/mscc/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/net/ethernet/mscc/ocelot_vsc7514.c:103:40: warning: 'ocelot_stats_layout' defined but not used [-Wunused-const-variable=] 103 | static const struct ocelot_stat_layout ocelot_stats_layout[OCELOT_NUM_STATS] = { | ^~~~~~~~~~~~~~~~~~~ vim +/ocelot_stats_layout +103 drivers/net/ethernet/mscc/ocelot_vsc7514.c d9feb904997333 Vladimir Oltean 2020-06-20 102 9190460084ddd0 Vladimir Oltean 2022-08-16 @103 static const struct ocelot_stat_layout ocelot_stats_layout[OCELOT_NUM_STATS] = { 4d1d157fb6a49f Vladimir Oltean 2022-09-08 104 OCELOT_COMMON_STATS, d9feb904997333 Vladimir Oltean 2020-06-20 105 }; d9feb904997333 Vladimir Oltean 2020-06-20 106 -- 0-DAY CI Kernel Test Service https://01.org/lkp