From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80208C43219 for ; Mon, 14 Nov 2022 17:50:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237762AbiKNRuG (ORCPT ); Mon, 14 Nov 2022 12:50:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237791AbiKNRty (ORCPT ); Mon, 14 Nov 2022 12:49:54 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8229525F2 for ; Mon, 14 Nov 2022 09:49:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1FC166132C for ; Mon, 14 Nov 2022 17:49:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E9C0C433D7; Mon, 14 Nov 2022 17:49:51 +0000 (UTC) Date: Mon, 14 Nov 2022 12:50:31 -0500 From: Steven Rostedt To: Linus Torvalds Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, Stephen Boyd , Guenter Roeck , Anna-Maria Gleixner , Andrew Morton , Julia Lawall , Eric Dumazet , Marcel Holtmann Subject: Re: [PATCH v6 4/6] timers: Add timer_shutdown_sync() to be called before freeing timers Message-ID: <20221114125031.19f8330c@gandalf.local.home> In-Reply-To: References: <20221110064101.429013735@goodmis.org> <20221110064147.343514404@goodmis.org> <875yfitpdu.ffs@tglx> <20221113191518.0a3b29b1@rorschach.local.home> <87sfims7ca.ffs@tglx> <87iljhsftt.ffs@tglx> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Nov 2022 09:16:31 -0800 Linus Torvalds wrote: > And honestly, for that to happen I'd be perfectly happy with something like > > #define timer_shutdown(t) del_timer(t) > #define timer_shutdown_sync(t) del_timer_sync(t) > > (obviously with the patches that first remove the existing > 'timer_shutdown()' uses first). That wouldn't introduce the *new* > semantics, but it would at least allow the different subsystems to do > the obvious cases, and let the networking people wonder about the much > less obvious ones. I can create the above series, if Thomas is OK with this approach. -- Steve