mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: <sre@kernel.org>, <orsonzhai@gmail.com>,
	<baolin.wang@linux.alibaba.com>, <zhang.lyra@gmail.com>,
	<gregkh@linuxfoundation.org>, <felipe.balbi@linux.intel.com>,
	<linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<patches@opensource.cirrus.com>, <linux-usb@vger.kernel.org>,
	<tony@atomide.com>
Subject: Re: [PATCH] usb: phy: add dedicated notifier for charger events
Date: Mon, 14 Nov 2022 14:03:43 +0000	[thread overview]
Message-ID: <20221114140343.GK10437@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <1668430562-27114-1-git-send-email-ivo.g.dimitrov.75@gmail.com>

On Mon, Nov 14, 2022 at 02:56:02PM +0200, Ivaylo Dimitrov wrote:
> usb_phy::notifier is already used by various PHY drivers (including
> phy_generic) to report VBUS status changes and its usage conflicts with
> charger current limit changes reporting.
> 
> Fix that by introducing a second notifier that is dedicated to usb charger
> notifications. Add usb_charger_XXX_notifier functions. Fix charger drivers
> that currently (ab)use usb_XXX_notifier() to use the new API.
> 
> Fixes: a9081a008f84 ("usb: phy: Add USB charger support")
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
>  drivers/power/supply/wm831x_power.c   |  7 ++++---

For the changes to wm831x looks fine to me:

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

  reply	other threads:[~2022-11-14 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 12:56 Ivaylo Dimitrov
2022-11-14 14:03 ` Charles Keepax [this message]
2022-11-14 16:14 ` Greg KH
2022-11-14 16:46   ` Ivaylo Dimitrov
2022-11-16  7:11     ` Ivaylo Dimitrov
2022-12-05 20:29       ` Ivaylo Dimitrov
2022-12-08 15:39       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221114140343.GK10437@ediswmail.ad.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®