From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Paul Durrant <paul@xen.org>
Subject: [PATCH] KVM: x86/xen: Make number of event channels defines less magical
Date: Mon, 14 Nov 2022 18:16:32 +0000 [thread overview]
Message-ID: <20221114181632.3279119-1-seanjc@google.com> (raw)
Use BITS_PER_BYTE and sizeof_field() to compute the number of Xen event
channels. The compat version at least uses sizeof_field(), but the
regular version open codes sizeof_field(), BITS_PER_BYTE, and combines
literals in the process, which makes it far too difficult to understand
relatively straightforward code.
No functional change intended.
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Paul Durrant <paul@xen.org>
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
arch/x86/kvm/xen.h | 8 +++++---
include/xen/interface/event_channel.h | 6 ++++--
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kvm/xen.h b/arch/x86/kvm/xen.h
index 532a535a9e99..c771fbed7058 100644
--- a/arch/x86/kvm/xen.h
+++ b/arch/x86/kvm/xen.h
@@ -9,6 +9,8 @@
#ifndef __ARCH_X86_KVM_XEN_H__
#define __ARCH_X86_KVM_XEN_H__
+#include <linux/bits.h>
+
#ifdef CONFIG_KVM_XEN
#include <linux/jump_label_ratelimit.h>
@@ -198,9 +200,9 @@ struct compat_shared_info {
struct compat_arch_shared_info arch;
};
-#define COMPAT_EVTCHN_2L_NR_CHANNELS (8 * \
- sizeof_field(struct compat_shared_info, \
- evtchn_pending))
+#define COMPAT_EVTCHN_2L_NR_CHANNELS \
+ (sizeof_field(struct compat_shared_info, evtchn_pending) * BITS_PER_BYTE)
+
struct compat_vcpu_runstate_info {
int state;
uint64_t state_entry_time;
diff --git a/include/xen/interface/event_channel.h b/include/xen/interface/event_channel.h
index 5f8da466e8a9..c7b97c206226 100644
--- a/include/xen/interface/event_channel.h
+++ b/include/xen/interface/event_channel.h
@@ -10,6 +10,8 @@
#ifndef __XEN_PUBLIC_EVENT_CHANNEL_H__
#define __XEN_PUBLIC_EVENT_CHANNEL_H__
+#include <linux/bits.h>
+
#include <xen/interface/xen.h>
typedef uint32_t evtchn_port_t;
@@ -244,8 +246,8 @@ DEFINE_GUEST_HANDLE_STRUCT(evtchn_op);
/*
* 2-level ABI
*/
-
-#define EVTCHN_2L_NR_CHANNELS (sizeof(xen_ulong_t) * sizeof(xen_ulong_t) * 64)
+#define EVTCHN_2L_NR_CHANNELS \
+ (sizeof_field(struct shared_info, evtchn_pending) * BITS_PER_BYTE)
/*
* FIFO ABI
base-commit: d663b8a285986072428a6a145e5994bc275df994
--
2.38.1.431.g37b22c650d-goog
next reply other threads:[~2022-11-14 18:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 18:16 Sean Christopherson [this message]
2022-11-14 18:39 ` David Woodhouse
2022-11-14 19:39 ` Sean Christopherson
2022-11-14 22:24 ` David Woodhouse
2022-11-22 20:31 ` Sean Christopherson
2022-11-22 23:48 ` David Woodhouse
2022-11-23 17:48 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114181632.3279119-1-seanjc@google.com \
--to=seanjc@google.com \
--cc=dwmw2@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®