mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: <vkoul@kernel.org>, <yung-chuan.liao@linux.intel.com>,
	<sanyog.r.kale@intel.com>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH 3/4] soundwire: debugfs: Switch to sdw_read_no_pm
Date: Tue, 15 Nov 2022 10:14:41 +0000	[thread overview]
Message-ID: <20221115101441.GL10437@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <bbc432e7-c52f-7e35-03d1-401cb68501cb@linux.intel.com>

On Mon, Nov 14, 2022 at 10:14:19AM -0600, Pierre-Louis Bossart wrote:
> 
> 
> On 11/14/22 04:29, Charles Keepax wrote:
> > It is rather inefficient to be constantly enabling/disabling the PM
> > runtime as we print out each individual register, switch to holding a PM
> > runtime reference across the whole register output.
> 
> the change is good, but technically the pm_runtime resume happens for
> the first read and suspend with a delay if use_autosuspend() is enabled,
> so presumably we'll see the same number of resume/suspend with the
> existing code and the suggested change.
> 
> Maybe update the commit message to mention that we constantly change
> reference counts, as you did in the next patch?

Yeah agree, I will respin the commit message.

Thanks,
Charles

  reply	other threads:[~2022-11-15 10:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-14 10:29 [PATCH 0/4] Minor SoundWire clean ups Charles Keepax
2022-11-14 10:29 ` [PATCH 1/4] soundwire: bus: export sdw_nwrite_no_pm and sdw_nread_no_pm functions Charles Keepax
2022-11-14 10:29 ` [PATCH 2/4] soundwire: Provide build stubs for common functions Charles Keepax
2022-11-14 16:13   ` Pierre-Louis Bossart
2022-11-15 11:03     ` Charles Keepax
2022-11-15 11:41       ` Richard Fitzgerald
2022-11-15 15:12         ` Pierre-Louis Bossart
2022-11-14 10:29 ` [PATCH 3/4] soundwire: debugfs: Switch to sdw_read_no_pm Charles Keepax
2022-11-14 16:14   ` Pierre-Louis Bossart
2022-11-15 10:14     ` Charles Keepax [this message]
2022-11-21 10:50   ` Dan Carpenter
2022-11-21 13:13     ` Charles Keepax
2022-11-14 10:29 ` [PATCH 4/4] soundwire: stream: Move remaining register accesses over to no_pm Charles Keepax
2022-11-14 16:04   ` Pierre-Louis Bossart
2022-11-15 11:05     ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221115101441.GL10437@ediswmail.ad.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®