From: Andrew Jones <ajones@ventanamicro.com>
To: Deepak Gupta <debug@rivosinc.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
aou@eecs.berkeley.edu, jan.kiszka@siemens.com,
kbingham@kernel.org, linux-kernel@vger.kernel.org,
palmer@dabbelt.com, paul.walmsley@sifive.com,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3] scripts/gdb: add lx_current support for riscv
Date: Tue, 15 Nov 2022 19:06:35 +0100 [thread overview]
Message-ID: <20221115180635.crej6pcvokdo3njy@kamzik> (raw)
In-Reply-To: <CAKC1njRi9C0m3JKpu0ebAFCC25161EST=tFFWiAj1yZBbnak6A@mail.gmail.com>
On Tue, Nov 15, 2022 at 09:49:10AM -0800, Deepak Gupta wrote:
...
> On Tue, Nov 15, 2022 at 6:38 AM Conor Dooley <conor.dooley@microchip.com>
> wrote:
>
> > Hey Deepak,
> >
> > On Tue, Nov 15, 2022 at 12:49:23AM -0800, Deepak Gupta wrote:
...
> > > + if (scratch_reg.cast(utils.get_ulong_type()) >
> > current_tp.cast(utils.get_ulong_type())):
> > ^^
> > extra space here?
>
>
> I don't see the space in the patch. Can you clarify which space you're
> talking about here?
The same one I pointed out in v2. The one after the greater-than sign.
Is your editor not using a monospaced font?
Thanks,
drew
next prev parent reply other threads:[~2022-11-15 18:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 19:59 Updating python gdb command lx_current " debug
2022-11-11 19:59 ` [PATCH] gdb-script: updated " debug
2022-11-13 0:13 ` Conor Dooley
2022-11-13 14:14 ` Conor Dooley
2022-11-13 11:06 ` Andrew Jones
2022-11-15 1:29 ` [PATCH v2] scripts/gdb: add lx_current support " Deepak Gupta
2022-11-15 6:46 ` Andrew Jones
2022-11-15 8:49 ` [PATCH v3] " Deepak Gupta
2022-11-15 14:38 ` Conor Dooley
[not found] ` <CAKC1njRi9C0m3JKpu0ebAFCC25161EST=tFFWiAj1yZBbnak6A@mail.gmail.com>
2022-11-15 18:06 ` Conor.Dooley
2022-11-15 18:43 ` Deepak Gupta
2022-11-15 18:06 ` Andrew Jones [this message]
2022-11-15 20:40 ` [PATCH v4] " Deepak Gupta
2022-11-15 21:23 ` Conor.Dooley
2022-11-15 22:10 ` [PATCH v5] " Deepak Gupta
2022-11-16 8:16 ` Andrew Jones
2022-11-16 22:24 ` Deepak Gupta
2022-12-09 1:24 ` Palmer Dabbelt
2023-01-02 9:09 ` Jan Kiszka
2023-10-05 5:29 ` Hsieh-Tseng Shen
2023-10-26 23:41 ` Deepak Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115180635.crej6pcvokdo3njy@kamzik \
--to=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=debug@rivosinc.com \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®