From: Yinjun Zhang <yinjun.zhang@corigine.com>
To: arefev@swemel.ru
Cc: davem@davemloft.net, kuba@kernel.org,
ldv-project@linuxtesting.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, oss-drivers@netronome.com,
simon.horman@netronome.com, trufanov@swemel.ru, vfh@swemel.ru
Subject: Re: [PATCH] lag_conf: Added pointer
Date: Wed, 16 Nov 2022 09:55:28 +0800 [thread overview]
Message-ID: <20221116015528.25334-1-yinjun.zhang@corigine.com> (raw)
In-Reply-To: <20221115085637.72193-1-arefev@swemel.ru>
On Tue, 15 Nov 2022 11:56:37 +0300, Denis Arefev wrote:
> <...>
> @@ -308,6 +308,8 @@ static void nfp_fl_lag_do_work(struct work_struct *work)
>
> acti_netdevs = kmalloc_array(entry->slave_cnt,
> sizeof(*acti_netdevs), GFP_KERNEL);
> + if (!acti_netdevs)
> + break;
I think we need give other entries and this entry itself one more chance by:
```
if (!acti_netdevs) {
schedule_delayed_work(&lag->work, NFP_FL_LAG_DELAY);
continue:
}
```
>
> /* Include sanity check in the loop. It may be that a bond has
> * changed between processing the last notification and the
prev parent reply other threads:[~2022-11-16 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 8:56 [PATCH] lag_conf: Added pointer check Denis Arefev
2022-11-15 9:22 ` Simon Horman
2022-11-16 1:55 ` Yinjun Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116015528.25334-1-yinjun.zhang@corigine.com \
--to=yinjun.zhang@corigine.com \
--cc=arefev@swemel.ru \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=trufanov@swemel.ru \
--cc=vfh@swemel.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®