mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/3] net: dsa: set name_assign_type to NET_NAME_ENUM for enumerated user ports
Date: Wed, 16 Nov 2022 11:52:04 +0100	[thread overview]
Message-ID: <20221116105205.1127843-4-linux@rasmusvillemoes.dk> (raw)
In-Reply-To: <20221116105205.1127843-1-linux@rasmusvillemoes.dk>

When a user port does not have a label in device tree, and we thus
fall back to the eth%d scheme, the proper constant to use is
NET_NAME_ENUM. See also commit e9f656b7a214 ("net: ethernet: set
default assignment identifier to NET_NAME_ENUM"), which in turn quoted
commit 685343fc3ba6 ("net: add name_assign_type netdev attribute"):

    ... when the kernel has given the interface a name using global
    device enumeration based on order of discovery (ethX, wlanY, etc)
    ... are labelled NET_NAME_ENUM.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
 net/dsa/slave.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index dfefcc4a9ccf..821ab79bb60a 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -2388,7 +2388,7 @@ int dsa_slave_create(struct dsa_port *port)
 		assign_type = NET_NAME_PREDICTABLE;
 	} else {
 		name = "eth%d";
-		assign_type = NET_NAME_UNKNOWN;
+		assign_type = NET_NAME_ENUM;
 	}
 
 	slave_dev = alloc_netdev_mqs(sizeof(struct dsa_slave_priv), name,
-- 
2.37.2


  parent reply	other threads:[~2022-11-16 11:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-11 16:17 [PATCH] net: dsa: use NET_NAME_PREDICTABLE for user ports with name given in DT Rasmus Villemoes
2022-11-11 17:10 ` Andrew Lunn
2022-11-13 20:03   ` Rasmus Villemoes
2022-11-15  2:17     ` Jakub Kicinski
2022-11-15 15:02       ` Andrew Lunn
2022-11-15  7:43 ` [PATCH v2] net: dsa: use more appropriate NET_NAME_* constants for user ports Rasmus Villemoes
2022-11-15 16:38   ` Jakub Kicinski
2022-11-15 18:55     ` Rasmus Villemoes
2022-11-16  1:59       ` Jakub Kicinski
2022-11-16 10:52   ` [PATCH v3 0/3] " Rasmus Villemoes
2022-11-16 10:52     ` [PATCH v3 1/3] net: dsa: refactor name assignment " Rasmus Villemoes
2022-11-16 13:40       ` Andrew Lunn
2022-11-16 16:22       ` Florian Fainelli
2022-11-16 10:52     ` [PATCH v3 2/3] net: dsa: use NET_NAME_PREDICTABLE for user ports with name given in DT Rasmus Villemoes
2022-11-16 13:41       ` Andrew Lunn
2022-11-16 16:22       ` Florian Fainelli
2022-11-16 10:52     ` Rasmus Villemoes [this message]
2022-11-16 13:42       ` [PATCH v3 3/3] net: dsa: set name_assign_type to NET_NAME_ENUM for enumerated user ports Andrew Lunn
2022-11-16 16:23       ` Florian Fainelli
2022-11-18  4:50     ` [PATCH v3 0/3] net: dsa: use more appropriate NET_NAME_* constants for " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221116105205.1127843-4-linux@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®