mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ChenXiaoSong <chenxiaosong2@huawei.com>
To: <clm@fb.com>, <josef@toxicpanda.com>, <dsterba@suse.com>
Cc: <linux-btrfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<chenxiaosong2@huawei.com>, <zhangxiaoxu5@huawei.com>,
	<yanaijie@huawei.com>, <quwenruo.btrfs@gmx.com>, <wqu@suse.com>
Subject: [PATCH v5 1/2] btrfs: add might_sleep() to btrfs_search_slot()
Date: Wed, 16 Nov 2022 21:07:15 +0800	[thread overview]
Message-ID: <20221116130716.991901-2-chenxiaosong2@huawei.com> (raw)
In-Reply-To: <20221116130716.991901-1-chenxiaosong2@huawei.com>

At least 2 places might sleep in btrfs_search_slot(), as shown below:

  btrfs_search_slot
    setup_nodes_for_search
      reada_for_balance
        btrfs_readahead_node_child
          btrfs_readahead_tree_block
            btrfs_find_create_tree_block
              alloc_extent_buffer
                kmem_cache_zalloc
                  /* allocate memory non-atomically, might sleep */
                  kmem_cache_alloc(GFP_NOFS|__GFP_NOFAIL|__GFP_ZERO)
            read_extent_buffer_pages
              submit_extent_page
                /* disk IO, might sleep */
                submit_one_bio

As the potential sleeping under spin lock is hard to spot, we should add
might_sleep() to btrfs_search_slot().

Signed-off-by: ChenXiaoSong <chenxiaosong2@huawei.com>
---
 fs/btrfs/ctree.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index a9543f01184c..809053e9cfde 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -1934,6 +1934,8 @@ int btrfs_search_slot(struct btrfs_trans_handle *trans, struct btrfs_root *root,
 	int min_write_lock_level;
 	int prev_cmp;
 
+	might_sleep();
+
 	lowest_level = p->lowest_level;
 	WARN_ON(lowest_level && ins_len > 0);
 	WARN_ON(p->nodes[0] != NULL);
-- 
2.31.1


  reply	other threads:[~2022-11-16 12:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 13:07 [PATCH v5 0/2] btrfs: fix sleep from invalid context bug in update_qgroup_limit_item() ChenXiaoSong
2022-11-16 13:07 ` ChenXiaoSong [this message]
2022-11-16 13:07 ` [PATCH v5 2/2] btrfs: qgroup: " ChenXiaoSong
2022-11-16 12:18   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221116130716.991901-2-chenxiaosong2@huawei.com \
    --to=chenxiaosong2@huawei.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    --cc=yanaijie@huawei.com \
    --cc=zhangxiaoxu5@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®