From: Xiaolei Wang <xiaolei.wang@windriver.com>
To: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] net: phy: Add link between phy dev and mac dev
Date: Wed, 16 Nov 2022 22:43:04 +0800 [thread overview]
Message-ID: <20221116144305.2317573-2-xiaolei.wang@windriver.com> (raw)
In-Reply-To: <20221116144305.2317573-1-xiaolei.wang@windriver.com>
The external phy used by current mac interface
is managed by another mac interface, so we should
create a device link between phy dev and mac dev.
Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
---
drivers/net/phy/phy.c | 20 ++++++++++++++++++++
include/linux/phy.h | 1 +
2 files changed, 21 insertions(+)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index e741d8aebffe..0ef6b69026c7 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -35,6 +35,7 @@
#include <net/netlink.h>
#include <net/genetlink.h>
#include <net/sock.h>
+#include <linux/of_mdio.h>
#define PHY_STATE_TIME HZ
@@ -1535,3 +1536,22 @@ int phy_ethtool_nway_reset(struct net_device *ndev)
return phy_restart_aneg(phydev);
}
EXPORT_SYMBOL(phy_ethtool_nway_reset);
+
+/**
+ * The external phy used by current mac interface is managed by
+ * another mac interface, so we should create a device link between
+ * phy dev and mac dev.
+ */
+void phy_mac_link_add(struct device_node *phy_np, struct net_device *ndev)
+{
+ struct phy_device *phy_dev = of_phy_find_device(phy_np);
+ struct device *dev = phy_dev ? &phy_dev->mdio.dev : NULL;
+
+ if (dev && ndev->dev.parent != dev)
+ device_link_add(ndev->dev.parent, dev,
+ DL_FLAG_PM_RUNTIME);
+
+ if (phy_dev)
+ put_device(&phy_dev->mdio.dev);
+}
+EXPORT_SYMBOL(phy_mac_link_add);
diff --git a/include/linux/phy.h b/include/linux/phy.h
index ddf66198f751..11cdfbd81153 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -1758,6 +1758,7 @@ int phy_package_join(struct phy_device *phydev, int addr, size_t priv_size);
void phy_package_leave(struct phy_device *phydev);
int devm_phy_package_join(struct device *dev, struct phy_device *phydev,
int addr, size_t priv_size);
+void phy_mac_link_add(struct device_node *phy_np, struct net_device *ndev);
#if IS_ENABLED(CONFIG_PHYLIB)
int __init mdio_bus_init(void);
--
2.25.1
next prev parent reply other threads:[~2022-11-16 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 14:43 [PATCH 0/2] " Xiaolei Wang
2022-11-16 14:43 ` Xiaolei Wang [this message]
2022-11-16 23:11 ` [PATCH 1/2] net: phy: " kernel test robot
2022-11-16 23:22 ` Florian Fainelli
2022-11-17 4:39 ` Wang, Xiaolei
2022-11-17 19:28 ` kernel test robot
2022-11-16 14:43 ` [PATCH 2/2] net: fec: Create device " Xiaolei Wang
2022-11-16 15:07 ` Andrew Lunn
2022-11-16 23:27 ` Florian Fainelli
2022-11-16 23:57 ` Andrew Lunn
2022-11-17 0:21 ` Florian Fainelli
2022-11-17 4:40 ` Wang, Xiaolei
2022-11-17 4:40 ` Wang, Xiaolei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221116144305.2317573-2-xiaolei.wang@windriver.com \
--to=xiaolei.wang@windriver.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®